Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-29 Thread Ulrich Obergfell
- Original Message - From: "Chris Metcalf" [...] > On 04/22/2015 04:20 AM, Ulrich Obergfell wrote: >> Chris, >> >> in principle the change looks o.k. to me, even though I'm not really familiar >> with the watchdog_nmi_disable_all() and watchdog_nmi_enable_all() functions. >> It is my under

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-28 Thread Chris Metcalf
On 04/22/2015 04:20 AM, Ulrich Obergfell wrote: Chris, in principle the change looks o.k. to me, even though I'm not really familiar with the watchdog_nmi_disable_all() and watchdog_nmi_enable_all() functions. It is my understanding that those functions are only called once via 'initcall' early

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-22 Thread Ulrich Obergfell
Chris, in principle the change looks o.k. to me, even though I'm not really familiar with the watchdog_nmi_disable_all() and watchdog_nmi_enable_all() functions. It is my understanding that those functions are only called once via 'initcall' early during kernel startup as shown in the following f

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-17 Thread Chris Metcalf
On 04/16/2015 09:31 PM, Chai Wen wrote: On 04/15/2015 03:37 AM, Chris Metcalf wrote: +/* + * The cpumask is the mask of possible cpus that the watchdog can run + * on, not the mask of cpus it is actually running on. This allows the + * user to specify a mask that will include cpus that have not

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-17 Thread Chris Metcalf
On 04/16/2015 06:46 AM, Ulrich Obergfell wrote: if a user changes watchdog parameters in /proc/sys/kernel, the watchdog threads are not stopped and restarted in all cases. Parameters can also be changed 'on the fly', for example like 'watchdog_thresh' in the following flow of execution: proc_

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-16 Thread Chai Wen
On 04/15/2015 03:37 AM, Chris Metcalf wrote: > Change the default behavior of watchdog so it only runs on the > housekeeping cores when nohz_full is enabled at build and boot time. > Allow modifying the set of cores the watchdog is currently running > on with a new kernel.watchdog_cpumask sysctl.

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-16 Thread Ulrich Obergfell
k you also need to review watchdog_nmi_disable_all() and watchdog_nmi_enable_all() because those functions call for_each_online_cpu() too. Regards, Uli Subject: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz Change the default behavior of watchdog so it only runs on the hou

[PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-14 Thread Chris Metcalf
Change the default behavior of watchdog so it only runs on the housekeeping cores when nohz_full is enabled at build and boot time. Allow modifying the set of cores the watchdog is currently running on with a new kernel.watchdog_cpumask sysctl. If we allowed the watchdog to run on nohz_full cores,