Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-15 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 15, 2021 at 03:09:28PM -0500, Rob Herring escreveu: > On Thu, Apr 15, 2021 at 2:37 PM Arnaldo Carvalho de Melo > wrote: > > Ok, b4 failed on it, probably some missing Reply to, so I'll apply it by > > hand: > > That's my fault. A duplicate message-id is the issue. git-send-email > di

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-15 Thread Rob Herring
On Thu, Apr 15, 2021 at 2:37 PM Arnaldo Carvalho de Melo wrote: > > Em Thu, Apr 15, 2021 at 04:14:31AM +0900, Namhyung Kim escreveu: > > On Thu, Apr 15, 2021 at 3:23 AM Arnaldo Carvalho de Melo > > wrote: > > > > > > Em Wed, Apr 14, 2021 at 03:02:08PM -0300, Arnaldo Carvalho de Melo > > > escrev

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-15 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 15, 2021 at 04:14:31AM +0900, Namhyung Kim escreveu: > On Thu, Apr 15, 2021 at 3:23 AM Arnaldo Carvalho de Melo > wrote: > > > > Em Wed, Apr 14, 2021 at 03:02:08PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Apr 15, 2021 at 01:41:35AM +0900, Namhyung Kim escreveu: > > > > H

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-14 Thread Namhyung Kim
On Thu, Apr 15, 2021 at 3:23 AM Arnaldo Carvalho de Melo wrote: > > Em Wed, Apr 14, 2021 at 03:02:08PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Apr 15, 2021 at 01:41:35AM +0900, Namhyung Kim escreveu: > > > Hello, > > > > > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring wrote: > > > >

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-14 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 14, 2021 at 03:02:08PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Apr 15, 2021 at 01:41:35AM +0900, Namhyung Kim escreveu: > > Hello, > > > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring wrote: > > > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int > > > th

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-14 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 15, 2021 at 01:41:35AM +0900, Namhyung Kim escreveu: > Hello, > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring wrote: > > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int thread) > > +{ > > + if (FD(evsel, cpu, thread) < 0 || MMAP(evsel, cpu, thread) == NULL) >

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-14 Thread Namhyung Kim
On Thu, Apr 15, 2021 at 1:53 AM Rob Herring wrote: > > On Wed, Apr 14, 2021 at 11:41 AM Namhyung Kim wrote: > > > > Hello, > > > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring wrote: > > > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int > > > thread) > > > +{ > > > + if

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-14 Thread Rob Herring
On Wed, Apr 14, 2021 at 11:41 AM Namhyung Kim wrote: > > Hello, > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring wrote: > > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int thread) > > +{ > > + if (FD(evsel, cpu, thread) < 0 || MMAP(evsel, cpu, thread) == NULL) > > +

Re: [PATCH v8 2/4] libperf: Add evsel mmap support

2021-04-14 Thread Namhyung Kim
Hello, On Thu, Apr 15, 2021 at 1:07 AM Rob Herring wrote: > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int thread) > +{ > + if (FD(evsel, cpu, thread) < 0 || MMAP(evsel, cpu, thread) == NULL) > + return NULL; I think you should check the cpu and the threa