Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-06-01 Thread Steven Rostedt
On Thu, 1 Jun 2017 14:25:51 +0200 Peter Zijlstra wrote: > On Thu, Jun 01, 2017 at 10:15:24AM +0200, Vlastimil Babka wrote: > > Thanks. I didn't make it clear that the trace_printk() warning is > > there even if the code using it doesn't actually execute (i.e. I > > didn't specify any early_printk

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-06-01 Thread Peter Zijlstra
On Thu, Jun 01, 2017 at 10:15:24AM +0200, Vlastimil Babka wrote: > Thanks. I didn't make it clear that the trace_printk() warning is there > even if the code using it doesn't actually execute (i.e. I didn't > specify any early_printk bootparam). There are some roastedy tricks to > detect the potent

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-06-01 Thread Vlastimil Babka
On 06/01/2017 05:37 AM, Lu Baolu wrote: > Hi, > > On 05/31/2017 05:38 PM, Vlastimil Babka wrote: >> On 05/31/2017 05:27 AM, Lu Baolu wrote: >>> Hi, >>> >>> On 05/30/2017 09:46 PM, Vlastimil Babka wrote: On 03/21/2017 09:01 AM, Lu Baolu wrote: Did you forget to remove the #define XDBC_TRA

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-05-31 Thread Lu Baolu
Hi, On 05/31/2017 05:38 PM, Vlastimil Babka wrote: > On 05/31/2017 05:27 AM, Lu Baolu wrote: >> Hi, >> >> On 05/30/2017 09:46 PM, Vlastimil Babka wrote: >>> On 03/21/2017 09:01 AM, Lu Baolu wrote: XHCI debug capability (DbC) is an optional but standalone functionality provided by an xHCI

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-05-31 Thread Lu Baolu
Hi, On 05/31/2017 02:24 PM, Steven Rostedt wrote: > On Wed, 31 May 2017 11:27:19 +0800 > Lu Baolu wrote: > > + +#define XDBC_TRACE +#ifdef XDBC_TRACE +#define xdbc_trace trace_printk >>> Did you forget to remove the #define XDBC_TRACE? >>> >>> Enabling this driver

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-05-31 Thread Vlastimil Babka
On 05/31/2017 05:27 AM, Lu Baolu wrote: > Hi, > > On 05/30/2017 09:46 PM, Vlastimil Babka wrote: >> On 03/21/2017 09:01 AM, Lu Baolu wrote: >>> XHCI debug capability (DbC) is an optional but standalone >>> functionality provided by an xHCI host controller. Software >>> learns this capability by wa

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-05-30 Thread Steven Rostedt
On Wed, 31 May 2017 11:27:19 +0800 Lu Baolu wrote: > >> + > >> +#define XDBC_TRACE > >> +#ifdef XDBC_TRACE > >> +#define xdbc_trace trace_printk > > Did you forget to remove the #define XDBC_TRACE? > > > > Enabling this driver brings the "trace_printk() being used. > > Allocating extr

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-05-30 Thread Lu Baolu
Hi, On 05/30/2017 09:46 PM, Vlastimil Babka wrote: > On 03/21/2017 09:01 AM, Lu Baolu wrote: >> XHCI debug capability (DbC) is an optional but standalone >> functionality provided by an xHCI host controller. Software >> learns this capability by walking through the extended >> capability list of t

Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-05-30 Thread Vlastimil Babka
On 03/21/2017 09:01 AM, Lu Baolu wrote: > XHCI debug capability (DbC) is an optional but standalone > functionality provided by an xHCI host controller. Software > learns this capability by walking through the extended > capability list of the host. XHCI specification describes > DbC in the section

[PATCH v8 2/5] usb: early: add driver for xhci debug capability

2017-03-21 Thread Lu Baolu
XHCI debug capability (DbC) is an optional but standalone functionality provided by an xHCI host controller. Software learns this capability by walking through the extended capability list of the host. XHCI specification describes DbC in the section 7.6. This patch introduces the code to probe and