Re: [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-12 Thread Matti Vaittinen
Thanks Again Lee, On Tue, Feb 12, 2019 at 09:17:23AM +, Lee Jones wrote: > On Fri, 08 Feb 2019, Matti Vaittinen wrote: > > > > I think an exported function with comments would be better. > > So do you mean you would prefer exported function over the pointer from > Yes please. Call-back

Re: [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-12 Thread Lee Jones
On Fri, 08 Feb 2019, Matti Vaittinen wrote: > Hello Lee, > > On Fri, Feb 08, 2019 at 10:57:43AM +, Lee Jones wrote: > > > > > > This is needed by both RTC and WDT drivers as RTC driver must stop the > > > WDT when it sets RTC. WDT HW is using RTC counter and might trigger > > >

Re: [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-08 Thread Matti Vaittinen
Hello Lee, On Fri, Feb 08, 2019 at 10:57:43AM +, Lee Jones wrote: > > > > This is needed by both RTC and WDT drivers as RTC driver must stop the > > WDT when it sets RTC. WDT HW is using RTC counter and might trigger > > timeout/reset when RTC is set. Options are to dublicate the > >

Re: [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-08 Thread Lee Jones
Mark, Something for you: > > > +/* bit [0] - Shutdown register */ > > > +unsigned int bit0_offsets[] = {0}; > > > +/* bit [1] - Power failure register */ > > > +unsigned int bit1_offsets[] = {1}; > > > +/* bit [2] - VR FAULT register */ > > > +unsigned int bit2_offsets[] = {2}; > > > +/* bit [3]

Re: [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-07 Thread Matti Vaittinen
Hello Again Lee, After a good night sleep few things came to my mind =) On Thu, Feb 07, 2019 at 02:00:53PM +, Lee Jones wrote: > On Thu, 07 Feb 2019, Matti Vaittinen wrote: > > > + > > +static struct mfd_cell bd70528_mfd_cells[] = { > > + { .name = "bd70528-pmic", }, > > + { .name =

Re: [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-07 Thread Matti Vaittinen
Hello Lee, Thanks for taking a look at this. On Thu, Feb 07, 2019 at 02:00:53PM +, Lee Jones wrote: > On Thu, 07 Feb 2019, Matti Vaittinen wrote: > > +// Copyright (C) 2018 ROHM Semiconductors > > This needs updating. Ok > > +#define BD70528_INT_RES(_reg, _name) \ > > + {

Re: [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-07 Thread Lee Jones
On Thu, 07 Feb 2019, Matti Vaittinen wrote: > ROHM BD70528MWV is an ultra-low quiescent current general > purpose single-chip power management IC for battery-powered > portable devices. > > Add MFD core which enables chip access for following subdevices: > - regulators/LED drivers >

[PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-02-06 Thread Matti Vaittinen
ROHM BD70528MWV is an ultra-low quiescent current general purpose single-chip power management IC for battery-powered portable devices. Add MFD core which enables chip access for following subdevices: - regulators/LED drivers - battery-charger - gpios - 32.768kHz