Re: [PATCH v8 3/3] leds: trigger: implement a tty trigger

2020-10-15 Thread kernel test robot
Hi "Uwe, I love your patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on pavel-linux-leds/for-next linus/master j.anaszewski-leds/for-next v5.9 next-20201015] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v8 3/3] leds: trigger: implement a tty trigger

2020-10-13 Thread Uwe Kleine-König
Hello, On Mon, Oct 12, 2020 at 10:16:59PM +0800, kernel test robot wrote: > Hi "Uwe, I love your test report! Perhaps something to improve: The parser of the From: line should drop the " :-) >drivers/leds/trigger/ledtrig-tty.c: In function 'ledtrig_tty_work': > >>

Re: [PATCH v8 3/3] leds: trigger: implement a tty trigger

2020-10-12 Thread kernel test robot
Hi "Uwe, I love your patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on pavel-linux-leds/for-next linus/master j.anaszewski-leds/for-next v5.9 next-20201012] [If your patch is applied to the wrong git tree, kindly drop us a note. And

[PATCH v8 3/3] leds: trigger: implement a tty trigger

2020-10-12 Thread Uwe Kleine-König
Usage is as follows: myled=ledname tty=ttyS0 echo tty > /sys/class/leds/$myled/trigger echo $tty > /sys/class/leds/$myled/ttyname . When this new trigger is active it periodically checks the tty's statistics and when it changed since the last check the led is