Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-17 Thread Jakub Kicinski
On Thu, 17 Dec 2020 12:46:57 +0100 Lukasz Stelmach wrote: > > to the correct values so the stack pre-allocates the needed spaces, > > when it can. > > Yes, I fonud these. However, I am not sure setting needed_tailroom has > any effect. In many places where alloc_skb() is called needed_headrom >

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-17 Thread Lukasz Stelmach
It was <2020-12-16 śro 08:13>, when Jakub Kicinski wrote: > On Wed, 16 Dec 2020 13:21:52 +0100 Lukasz Stelmach wrote: >> So, the only thing that's left is pskb_expand_head(). I need to wrap my >> head around it. Can you tell me how a cloned skb is different and why >> there may be separate branch

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 13:21:52 +0100 Lukasz Stelmach wrote: > So, the only thing that's left is pskb_expand_head(). I need to wrap my > head around it. Can you tell me how a cloned skb is different and why > there may be separate branch for it? I think this driver needs to prepend and append some

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-16 Thread Lukasz Stelmach
It was <2020-12-15 wto 17:46>, when Jakub Kicinski wrote: > On Wed, 16 Dec 2020 01:42:03 +0100 Lukasz Stelmach wrote: + ax_local->stats.rx_packets++; + ax_local->stats.rx_bytes += skb->len; + skb->dev = ndev; + + skb->truesize = skb->len + sizeof(struct sk_buff); >>>

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-15 Thread Jakub Kicinski
On Wed, 16 Dec 2020 01:42:03 +0100 Lukasz Stelmach wrote: > >> + ax_local->stats.rx_packets++; > >> + ax_local->stats.rx_bytes += skb->len; > >> + skb->dev = ndev; > >> + > >> + skb->truesize = skb->len + sizeof(struct sk_buff); > > > > Why do you modify truesize? > > > > I don't know.

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-15 Thread Lukasz Stelmach
It was <2020-12-04 pią 19:37>, when Jakub Kicinski wrote: > On Wed, 2 Dec 2020 22:47:09 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> Before

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 22:47:09 +0100 Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] >

[PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which