Re: [PATCH v8 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-08-21 Thread Peter Zijlstra
On Tue, 2012-08-21 at 17:40 +0300, Michael S. Tsirkin wrote: > > + spin_lock(&vb->pages_lock); > > + page = list_first_or_null_rcu(&vb->pages, struct page, lru); > > Why is list_first_or_null_rcu called outside > RCU critical section here? It looks like vb->pages_lock is t

Re: [PATCH v8 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-08-21 Thread Peter Zijlstra
On Tue, 2012-08-21 at 17:40 +0300, Michael S. Tsirkin wrote: > > + vb->balloon_status = BALLOON_REMOVAL; > > This needs some kind of barrier. > > > kthread_stop(vb->thread); kthread_stop() implies an smp_wmb() [ because it needs to do a wakeup ]. -- To unsubscribe from this list: send

Re: [PATCH v8 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-08-21 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 09:47:46AM -0300, Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > trans

Re: [PATCH v8 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-08-21 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 09:47:46AM -0300, Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of > trans

[PATCH v8 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-08-21 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. Besides ma