Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-11 Thread Tamir Duberstein
On Thu, Mar 6, 2025 at 4:38 AM Petr Mladek wrote: > > On Wed 2025-03-05 10:57:47, Tamir Duberstein wrote: > > On Wed, Mar 5, 2025 at 10:55 AM Andy Shevchenko > > wrote: > > > > > > On Wed, Mar 05, 2025 at 10:25:51AM -0500, Tamir Duberstein wrote: > > > > On Wed, Mar 5, 2025 at 10:01 AM Petr Mlade

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-06 Thread Petr Mladek
On Wed 2025-03-05 10:57:47, Tamir Duberstein wrote: > On Wed, Mar 5, 2025 at 10:55 AM Andy Shevchenko > wrote: > > > > On Wed, Mar 05, 2025 at 10:25:51AM -0500, Tamir Duberstein wrote: > > > On Wed, Mar 5, 2025 at 10:01 AM Petr Mladek wrote: > > > > On Fri 2025-02-14 11:20:01, Tamir Duberstein wr

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-05 Thread Tamir Duberstein
On Wed, Mar 5, 2025 at 2:35 PM Andy Shevchenko wrote: > > On Wed, Mar 05, 2025 at 10:57:47AM -0500, Tamir Duberstein wrote: > > On Wed, Mar 5, 2025 at 10:55 AM Andy Shevchenko > > wrote: > > > On Wed, Mar 05, 2025 at 10:25:51AM -0500, Tamir Duberstein wrote: > > > > On Wed, Mar 5, 2025 at 10:01 A

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:57:47AM -0500, Tamir Duberstein wrote: > On Wed, Mar 5, 2025 at 10:55 AM Andy Shevchenko > wrote: > > On Wed, Mar 05, 2025 at 10:25:51AM -0500, Tamir Duberstein wrote: > > > On Wed, Mar 5, 2025 at 10:01 AM Petr Mladek wrote: > > > > On Fri 2025-02-14 11:20:01, Tamir Dub

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-05 Thread Tamir Duberstein
On Wed, Mar 5, 2025 at 10:55 AM Andy Shevchenko wrote: > > On Wed, Mar 05, 2025 at 10:25:51AM -0500, Tamir Duberstein wrote: > > On Wed, Mar 5, 2025 at 10:01 AM Petr Mladek wrote: > > > On Fri 2025-02-14 11:20:01, Tamir Duberstein wrote: > > ... > > > > > #include > > > > -#include > > > > -#i

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:25:51AM -0500, Tamir Duberstein wrote: > On Wed, Mar 5, 2025 at 10:01 AM Petr Mladek wrote: > > On Fri 2025-02-14 11:20:01, Tamir Duberstein wrote: ... > > > #include > > > -#include > > > -#include > > > #include > > > -#include > > > -#include > > > #include

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 04:01:48PM +0100, Petr Mladek wrote: > On Fri 2025-02-14 11:20:01, Tamir Duberstein wrote: ... > > #include > > -#include > > -#include > > #include > > -#include > > -#include > > #include > > #include > > -#include > > +#include > > > > #define BUF_SIZE

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-05 Thread Tamir Duberstein
On Wed, Mar 5, 2025 at 10:01 AM Petr Mladek wrote: > > On Fri 2025-02-14 11:20:01, Tamir Duberstein wrote: > > Use `suite_init` and move some tests into `scanf_test_cases`. This > > gives us nicer output in the event of a failure. > > > > Reviewed-by: David Gow > > Signed-off-by: Tamir Duberstein

Re: [PATCH v8 4/4] scanf: break kunit into test cases

2025-03-05 Thread Petr Mladek
On Fri 2025-02-14 11:20:01, Tamir Duberstein wrote: > Use `suite_init` and move some tests into `scanf_test_cases`. This > gives us nicer output in the event of a failure. > > Reviewed-by: David Gow > Signed-off-by: Tamir Duberstein > --- > lib/tests/scanf_kunit.c | 95 > ++

[PATCH v8 4/4] scanf: break kunit into test cases

2025-02-14 Thread Tamir Duberstein
Use `suite_init` and move some tests into `scanf_test_cases`. This gives us nicer output in the event of a failure. Reviewed-by: David Gow Signed-off-by: Tamir Duberstein --- lib/tests/scanf_kunit.c | 95 ++--- 1 file changed, 51 insertions(+), 44 del