Re: [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-06-12 Thread Jonathan Richardson
On 15-06-12 02:49 AM, Thierry Reding wrote: > On Tue, May 26, 2015 at 01:08:20PM -0700, Jonathan Richardson wrote: >> The pwm_enable function didn't clear the enabled bit if a call to a >> clients enable function returned an error. The result was that the state >> of the pwm core was wrong.

Re: [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-06-12 Thread Thierry Reding
On Tue, May 26, 2015 at 01:08:20PM -0700, Jonathan Richardson wrote: > The pwm_enable function didn't clear the enabled bit if a call to a > clients enable function returned an error. The result was that the state > of the pwm core was wrong. Clearing the bit when enable returns an error > ensures

Re: [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-06-12 Thread Thierry Reding
On Tue, May 26, 2015 at 01:08:20PM -0700, Jonathan Richardson wrote: The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the

Re: [PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-06-12 Thread Jonathan Richardson
On 15-06-12 02:49 AM, Thierry Reding wrote: On Tue, May 26, 2015 at 01:08:20PM -0700, Jonathan Richardson wrote: The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the

[PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-26 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson Reviewed-by:

[PATCH v8 5/5] pwm: core: Set enable state properly on failed call to enable

2015-05-26 Thread Jonathan Richardson
The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Tested-by: Jonathan Richardson