Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-11 Thread Dmitry Torokhov
On Wed, Jul 11, 2012 at 09:49:04AM +0200, Roland Stigge wrote: > On 07/10/2012 10:55 PM, Dmitry Torokhov wrote: > > Hi Roland, > > > > On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: > >> This patch adds a driver for the key scan interface of the LPC32xx SoC > >> > > > > Could of m

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-11 Thread Roland Stigge
On 07/10/2012 10:55 PM, Dmitry Torokhov wrote: > Hi Roland, > > On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: >> This patch adds a driver for the key scan interface of the LPC32xx SoC >> > > Could of more things that I had in my patch but forgot to specifically > call out: > >>

Re: [PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Dmitry Torokhov
Hi Roland, On Tue, Jul 10, 2012 at 09:35:10PM +0200, Roland Stigge wrote: > This patch adds a driver for the key scan interface of the LPC32xx SoC > Could of more things that I had in my patch but forgot to specifically call out: > + > + /* Configure the key scanner */ > + clk_prepare_e

[PATCH v9] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Roland Stigge
This patch adds a driver for the key scan interface of the LPC32xx SoC Signed-off-by: Roland Stigge --- Applies to v3.5-rc6 Changes since v8: * Optimized lpc32xx_mod_states() to shift "changed" word and break on 0 * lpc32xx_parse_dt(): Return -EINVAL instead of -ENXIO * kfree() of keymap _after