Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-25 Thread Yash Shah
On Mon, Mar 25, 2019 at 5:28 PM Andreas Schwab wrote: > > On Mär 25 2019, Yash Shah wrote: > > > I have sent out the v11 patchset, you can test the heartbeat > > application with that patchset. > > You still need to make that DT file modification which you previously > > did, using fsbl.bin > >

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-25 Thread Andreas Schwab
On Mär 25 2019, Yash Shah wrote: > I have sent out the v11 patchset, you can test the heartbeat > application with that patchset. > You still need to make that DT file modification which you previously > did, using fsbl.bin Why can't the driver make use of sifive,approx-period? Andreas. --

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-25 Thread Yash Shah
Hi Andreas, On Tue, Mar 19, 2019 at 11:56 AM Yash Shah wrote: > > On Mon, Mar 18, 2019 at 10:56 PM Andreas Schwab wrote: > > > > On Mär 15 2019, Yash Shah wrote: > > > > > You need to make sure the period setting is passed via the > > > conventional way in DT file. > > > Example: > > > pwmleds

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-19 Thread Yash Shah
On Mon, Mar 18, 2019 at 10:56 PM Andreas Schwab wrote: > > On Mär 15 2019, Yash Shah wrote: > > > You need to make sure the period setting is passed via the > > conventional way in DT file. > > Example: > > pwmleds { > > compatible = "pwm-leds"; > > heartbeat { > > pwms = < 0

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-18 Thread Andreas Schwab
On Mär 15 2019, Yash Shah wrote: > You need to make sure the period setting is passed via the > conventional way in DT file. > Example: > pwmleds { > compatible = "pwm-leds"; > heartbeat { > pwms = < 0 1000 0>; > max-brightness = <255>; > linux,default-trigger

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-18 Thread Andreas Schwab
On Mär 15 2019, Yash Shah wrote: > Use the open-source FSBL from: > https://github.com/sifive/freedom-u540-c000-bootloader > > Modify the fsbl/ux00_fsbl.dts file and re-build the fsbl.bin That doesn't even compile. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint =

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-15 Thread Yash Shah
On Tue, Mar 12, 2019 at 3:44 PM Andreas Schwab wrote: > > On Mär 12 2019, Yash Shah wrote: > > > This patch series adds a PWM driver and DT documentation > > for HiFive Unleashed board. The patches are mostly based on > > Wesley's patch. > > Heartbeat trigger still doesn't work for me. You need

Re: [PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-12 Thread Andreas Schwab
On Mär 12 2019, Yash Shah wrote: > This patch series adds a PWM driver and DT documentation > for HiFive Unleashed board. The patches are mostly based on > Wesley's patch. Heartbeat trigger still doesn't work for me. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint =

[PATCH v9 0/2] PWM support for HiFive Unleashed

2019-03-12 Thread Yash Shah
This patch series adds a PWM driver and DT documentation for HiFive Unleashed board. The patches are mostly based on Wesley's patch. v9 - Use appropriate bitfield macros - Add approx_period in pwm_sifive_ddata struct and related changes - Correct the eqn for calculation of frac (in