Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-18 Thread Jarkko Sakkinen
On Wed, Jul 13, 2016 at 09:19:31AM -0700, Ed Swierk wrote: > v9: Include command duration in existing error messages rather than > logging an extra debug message. Rebase onto Jarkko's tree. > > v8: Fix v7 goof-up in tpm_getcap(). > > v7: Use tpm_getcap() instead of a redundant new function. > >

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-18 Thread Jarkko Sakkinen
On Wed, Jul 13, 2016 at 09:19:31AM -0700, Ed Swierk wrote: > v9: Include command duration in existing error messages rather than > logging an extra debug message. Rebase onto Jarkko's tree. > > v8: Fix v7 goof-up in tpm_getcap(). > > v7: Use tpm_getcap() instead of a redundant new function. > >

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Eric W. Biederman
Ed Swierk writes: > On Wed, Jul 13, 2016 at 10:36 AM, Jason Gunthorpe > wrote: >> I think your bios is broken? > > The BIOS is broken in many ways. I already have to pass > memmap=256M$0x8000, otherwise PCIe extended config space

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Eric W. Biederman
Ed Swierk writes: > On Wed, Jul 13, 2016 at 10:36 AM, Jason Gunthorpe > wrote: >> I think your bios is broken? > > The BIOS is broken in many ways. I already have to pass > memmap=256M$0x8000, otherwise PCIe extended config space > (MMCONFIG) is inaccessible. Also I found

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Jason Gunthorpe
On Wed, Jul 13, 2016 at 01:00:28PM -0700, Ed Swierk wrote: > On Wed, Jul 13, 2016 at 10:36 AM, Jason Gunthorpe > wrote: > > I think your bios is broken? > > The BIOS is broken in many ways. I already have to pass > memmap=256M$0x8000, otherwise PCIe extended

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Jason Gunthorpe
On Wed, Jul 13, 2016 at 01:00:28PM -0700, Ed Swierk wrote: > On Wed, Jul 13, 2016 at 10:36 AM, Jason Gunthorpe > wrote: > > I think your bios is broken? > > The BIOS is broken in many ways. I already have to pass > memmap=256M$0x8000, otherwise PCIe extended config space > (MMCONFIG) is

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Ed Swierk
On Wed, Jul 13, 2016 at 10:36 AM, Jason Gunthorpe wrote: > I think your bios is broken? The BIOS is broken in many ways. I already have to pass memmap=256M$0x8000, otherwise PCIe extended config space (MMCONFIG) is inaccessible. Also I found

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Ed Swierk
On Wed, Jul 13, 2016 at 10:36 AM, Jason Gunthorpe wrote: > I think your bios is broken? The BIOS is broken in many ways. I already have to pass memmap=256M$0x8000, otherwise PCIe extended config space (MMCONFIG) is inaccessible. Also I found memmap=0x7000$0x7a7d works around "APEI: Can

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Jason Gunthorpe
On Wed, Jul 13, 2016 at 09:44:05AM -0700, Ed Swierk wrote: > On Wed, Jul 13, 2016 at 9:19 AM, Ed Swierk wrote: > > v9: Include command duration in existing error messages rather than > > logging an extra debug message. Rebase onto Jarkko's tree. > > Incidentally, with

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Jason Gunthorpe
On Wed, Jul 13, 2016 at 09:44:05AM -0700, Ed Swierk wrote: > On Wed, Jul 13, 2016 at 9:19 AM, Ed Swierk wrote: > > v9: Include command duration in existing error messages rather than > > logging an extra debug message. Rebase onto Jarkko's tree. > > Incidentally, with Jarkko's tree the tpm_tis

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Ed Swierk
On Wed, Jul 13, 2016 at 9:19 AM, Ed Swierk wrote: > v9: Include command duration in existing error messages rather than > logging an extra debug message. Rebase onto Jarkko's tree. Incidentally, with Jarkko's tree the tpm_tis module refuses to initialize (with or

Re: [PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Ed Swierk
On Wed, Jul 13, 2016 at 9:19 AM, Ed Swierk wrote: > v9: Include command duration in existing error messages rather than > logging an extra debug message. Rebase onto Jarkko's tree. Incidentally, with Jarkko's tree the tpm_tis module refuses to initialize (with or without force=1): tpm_tis

[PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Ed Swierk
v9: Include command duration in existing error messages rather than logging an extra debug message. Rebase onto Jarkko's tree. v8: Fix v7 goof-up in tpm_getcap(). v7: Use tpm_getcap() instead of a redundant new function. v6: Split tpm_get_cap_prop() out of tpm_get_timeouts(); always return

[PATCH v9 0/5] tpm: Command duration logging and chip-specific override

2016-07-13 Thread Ed Swierk
v9: Include command duration in existing error messages rather than logging an extra debug message. Rebase onto Jarkko's tree. v8: Fix v7 goof-up in tpm_getcap(). v7: Use tpm_getcap() instead of a redundant new function. v6: Split tpm_get_cap_prop() out of tpm_get_timeouts(); always return