Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-02-15 Thread Dan Williams
On Thu, Jan 20, 2022 at 6:22 PM Darrick J. Wong wrote: > > On Fri, Jan 21, 2022 at 09:26:52AM +0800, Shiyang Ruan wrote: > > > > > > 在 2022/1/20 16:46, Christoph Hellwig 写道: > > > On Wed, Jan 05, 2022 at 04:12:04PM -0800, Dan Williams wrote: > > > > We ended up with explicit callbacks after hch

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-20 Thread Christoph Hellwig
On Thu, Jan 20, 2022 at 06:22:00PM -0800, Darrick J. Wong wrote: > Hm, so that means XFS can only support dax+pmem when there aren't > partitions in use? Ew. Yes. Or any sensible DAX usage going forward for that matter. > > > > (2) extent the holder mechanism to cover a rangeo > > I don't

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-20 Thread Darrick J. Wong
On Fri, Jan 21, 2022 at 09:26:52AM +0800, Shiyang Ruan wrote: > > > 在 2022/1/20 16:46, Christoph Hellwig 写道: > > On Wed, Jan 05, 2022 at 04:12:04PM -0800, Dan Williams wrote: > > > We ended up with explicit callbacks after hch balked at a notifier > > > call-chain, but I think we're back to that

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-20 Thread Shiyang Ruan
在 2022/1/20 16:46, Christoph Hellwig 写道: On Wed, Jan 05, 2022 at 04:12:04PM -0800, Dan Williams wrote: We ended up with explicit callbacks after hch balked at a notifier call-chain, but I think we're back to that now. The partition mistake might be unfixable, but at least bdev_dax_pgoff() is

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-20 Thread Christoph Hellwig
On Wed, Jan 05, 2022 at 04:12:04PM -0800, Dan Williams wrote: > We ended up with explicit callbacks after hch balked at a notifier > call-chain, but I think we're back to that now. The partition mistake > might be unfixable, but at least bdev_dax_pgoff() is dead. Notifier > call chains have their

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 3:54 PM Darrick J. Wong wrote: [..] > > Yes, I think we should just fail the holder registration and > > DAX+reflink unless the FS being mounted on a whole device. I know Ted > > and others had reservations about moving filesystems to be mounted on > > dax-devices directly,

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Wed, Jan 05, 2022 at 03:01:22PM -0800, Dan Williams wrote: > On Wed, Jan 5, 2022 at 2:47 PM Darrick J. Wong wrote: > > > > On Wed, Jan 05, 2022 at 11:20:12AM -0800, Dan Williams wrote: > > > On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > > > > > > > On Wed, Jan 05, 2022 at

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 2:47 PM Darrick J. Wong wrote: > > On Wed, Jan 05, 2022 at 11:20:12AM -0800, Dan Williams wrote: > > On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > > > > > On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > > > > On Wed, Jan 5, 2022 at 10:12 AM

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Wed, Jan 05, 2022 at 11:20:12AM -0800, Dan Williams wrote: > On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > > > On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > > > On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > > > > > > > On Sun, Dec 26, 2021 at

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 10:56 AM Darrick J. Wong wrote: > > On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > > On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > > > > > On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > > > > To easily track filesystem from a

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Wed, Jan 05, 2022 at 10:23:08AM -0800, Dan Williams wrote: > On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > > > On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > > > To easily track filesystem from a pmem device, we introduce a holder for > > > dax_device structure,

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Dan Williams
On Wed, Jan 5, 2022 at 10:12 AM Darrick J. Wong wrote: > > On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > > To easily track filesystem from a pmem device, we introduce a holder for > > dax_device structure, and also its operation. This holder is used to > > remember who is using

Re: [PATCH v9 02/10] dax: Introduce holder for dax_device

2022-01-05 Thread Darrick J. Wong
On Sun, Dec 26, 2021 at 10:34:31PM +0800, Shiyang Ruan wrote: > To easily track filesystem from a pmem device, we introduce a holder for > dax_device structure, and also its operation. This holder is used to > remember who is using this dax_device: > - When it is the backend of a filesystem, the

[PATCH v9 02/10] dax: Introduce holder for dax_device

2021-12-26 Thread Shiyang Ruan
To easily track filesystem from a pmem device, we introduce a holder for dax_device structure, and also its operation. This holder is used to remember who is using this dax_device: - When it is the backend of a filesystem, the holder will be the instance of this filesystem. - When this pmem