[PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-25 Thread Dan Murphy
Introduce a multicolor class that groups colored LEDs within a LED node. The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness. The former is controlled via _intensity files and the latter is controlled via brightness file.

Re: [PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-25 Thread Jacek Anaszewski
Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: > Introduce a multicolor class that groups colored LEDs > within a LED node. > > The multi color class groups monochrome LEDs and allows controlling two > aspects of the final combined color: hue and lightness. The former is > controlled via _intensity f

Re: [PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-26 Thread Dan Murphy
Jacek On 9/25/19 4:12 PM, Jacek Anaszewski wrote: Dan, On 9/25/19 7:46 PM, Dan Murphy wrote: Introduce a multicolor class that groups colored LEDs within a LED node. The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness.

Re: [PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-28 Thread Jacek Anaszewski
Dan, On 9/26/19 1:52 PM, Dan Murphy wrote: > Jacek > > On 9/25/19 4:12 PM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/25/19 7:46 PM, Dan Murphy wrote: >>> Introduce a multicolor class that groups colored LEDs >>> within a LED node. >>> >>> The multi color class groups monochrome LEDs and allows c

Re: [PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-28 Thread Jacek Anaszewski
On 9/28/19 12:09 PM, Jacek Anaszewski wrote: > Dan, [...] >>> >>> +    brightness_val[i] = brightness * +    priv->intensity / priv->max_intensity; > > Now, looking closer at this equation it becomes obvious to me > why Pavel opted for common max_brightness: in case o