Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-30 Thread Matthias Brugger
On 10/28/2016 11:36 AM, James Liao wrote: Hi Matthias, Sorry for late reply due to our email service. On Tue, 2016-10-25 at 16:04 +0200, Matthias Brugger wrote: Hi James, On 10/20/2016 10:56 AM, James Liao wrote: -static int scpsys_probe(struct platform_device *pdev) +static void

Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-30 Thread Matthias Brugger
On 10/28/2016 11:36 AM, James Liao wrote: Hi Matthias, Sorry for late reply due to our email service. On Tue, 2016-10-25 at 16:04 +0200, Matthias Brugger wrote: Hi James, On 10/20/2016 10:56 AM, James Liao wrote: -static int scpsys_probe(struct platform_device *pdev) +static void

Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-28 Thread James Liao
Hi Matthias, Sorry for late reply due to our email service. On Tue, 2016-10-25 at 16:04 +0200, Matthias Brugger wrote: > Hi James, > > On 10/20/2016 10:56 AM, James Liao wrote: > > -static int scpsys_probe(struct platform_device *pdev) > > +static void init_clks(struct platform_device *pdev,

Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-28 Thread James Liao
Hi Matthias, Sorry for late reply due to our email service. On Tue, 2016-10-25 at 16:04 +0200, Matthias Brugger wrote: > Hi James, > > On 10/20/2016 10:56 AM, James Liao wrote: > > -static int scpsys_probe(struct platform_device *pdev) > > +static void init_clks(struct platform_device *pdev,

Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-25 Thread Matthias Brugger
Hi James, On 10/20/2016 10:56 AM, James Liao wrote: -static int scpsys_probe(struct platform_device *pdev) +static void init_clks(struct platform_device *pdev, struct clk *clk[CLK_MAX]) I prefer struct clk **clk. +{ + int i; + + for (i = CLK_NONE + 1; i < CLK_MAX; i++) +

Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-25 Thread Matthias Brugger
Hi James, On 10/20/2016 10:56 AM, James Liao wrote: -static int scpsys_probe(struct platform_device *pdev) +static void init_clks(struct platform_device *pdev, struct clk *clk[CLK_MAX]) I prefer struct clk **clk. +{ + int i; + + for (i = CLK_NONE + 1; i < CLK_MAX; i++) +

[PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-20 Thread James Liao
Refine scpsys driver common code to support multiple SoC / platform. Signed-off-by: James Liao Reviewed-by: Kevin Hilman --- drivers/soc/mediatek/mtk-scpsys.c | 348 +++--- 1 file changed, 210 insertions(+), 138

[PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform

2016-10-20 Thread James Liao
Refine scpsys driver common code to support multiple SoC / platform. Signed-off-by: James Liao Reviewed-by: Kevin Hilman --- drivers/soc/mediatek/mtk-scpsys.c | 348 +++--- 1 file changed, 210 insertions(+), 138 deletions(-) diff --git