Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-12 Thread wuqiang.matt
On 2023/10/13 09:59, Masami Hiramatsu (Google) wrote: On Fri, 13 Oct 2023 01:36:05 +0800 "wuqiang.matt" wrote: On 2023/10/12 22:02, Masami Hiramatsu (Google) wrote: Hi Wuqiang, On Mon, 9 Oct 2023 17:23:34 +0800 wuqiang wrote: Hello Masami, Just got time for the new patch and got that age

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-12 Thread Google
On Fri, 13 Oct 2023 01:36:05 +0800 "wuqiang.matt" wrote: > On 2023/10/12 22:02, Masami Hiramatsu (Google) wrote: > > Hi Wuqiang, > > > > On Mon, 9 Oct 2023 17:23:34 +0800 > > wuqiang wrote: > > > >> Hello Masami, > >> > >> Just got time for the new patch and got that ages[] was removed. ages[]

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-12 Thread wuqiang.matt
On 2023/10/12 22:02, Masami Hiramatsu (Google) wrote: Hi Wuqiang, On Mon, 9 Oct 2023 17:23:34 +0800 wuqiang wrote: Hello Masami, Just got time for the new patch and got that ages[] was removed. ages[] is introduced the way like 2-phase commit to keep consitency and must be kept. Thinking of

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-12 Thread wuqiang.matt
Hello Masami, I've udpated the objpool patch and did some function testings for X64 and ARM64. Later I'll do the performance testings and more regressions. Here are the changelogs: 1) new struct objpool_node added to represent the real percpu ring arrary and struct objpool_slot now represents

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-12 Thread Google
Hi Wuqiang, On Mon, 9 Oct 2023 17:23:34 +0800 wuqiang wrote: > Hello Masami, > > Just got time for the new patch and got that ages[] was removed. ages[] is > introduced the way like 2-phase commit to keep consitency and must be kept. > > Thinking of the following 2 cases that two cpu nodes are

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-09 Thread Google
Hi, On Mon, 9 Oct 2023 02:40:53 +0800 wuqiang wrote: > On 2023/9/23 17:48, Masami Hiramatsu (Google) wrote: > > Hi Wuqiang, > > > > Sorry for replying later. > > > > On Tue, 5 Sep 2023 09:52:51 +0800 > > "wuqiang.matt" wrote: > > > >> The object pool is a scalable implementaion of high perf

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-09 Thread Google
On Mon, 9 Oct 2023 17:23:34 +0800 wuqiang wrote: > Hello Masami, > > Just got time for the new patch and got that ages[] was removed. ages[] is > introduced the way like 2-phase commit to keep consitency and must be kept. > > Thinking of the following 2 cases that two cpu nodes are operating th

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-09 Thread wuqiang
Hello Masami, Just got time for the new patch and got that ages[] was removed. ages[] is introduced the way like 2-phase commit to keep consitency and must be kept. Thinking of the following 2 cases that two cpu nodes are operating the same objpool_slot simultaneously: Case 1: NODE 1:

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-08 Thread wuqiang
On 2023/9/25 17:42, Masami Hiramatsu (Google) wrote: Hi Wuqiang, On Tue, 5 Sep 2023 09:52:51 +0800 "wuqiang.matt" wrote: The object pool is a scalable implementaion of high performance queue for object allocation and reclamation, such as kretprobe instances. With leveraging percpu ring-arra

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-10-08 Thread wuqiang
On 2023/9/23 17:48, Masami Hiramatsu (Google) wrote: Hi Wuqiang, Sorry for replying later. On Tue, 5 Sep 2023 09:52:51 +0800 "wuqiang.matt" wrote: The object pool is a scalable implementaion of high performance queue for object allocation and reclamation, such as kretprobe instances. With

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-09-25 Thread Google
Hi Wuqiang, On Tue, 5 Sep 2023 09:52:51 +0800 "wuqiang.matt" wrote: > The object pool is a scalable implementaion of high performance queue > for object allocation and reclamation, such as kretprobe instances. > > With leveraging percpu ring-array to mitigate the hot spot of memory > contentio

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-09-24 Thread Google
Hi, On Tue, 5 Sep 2023 09:52:51 +0800 "wuqiang.matt" wrote: > +/* cleanup all percpu slots of the object pool */ > +static void objpool_fini_percpu_slots(struct objpool_head *head) > +{ > + int i; > + > + if (!head->cpu_slots) > + return; > + > + for (i = 0; i < head->nr

Re: [PATCH v9 1/5] lib: objpool added: ring-array based lockless MPMC

2023-09-23 Thread Google
Hi Wuqiang, Sorry for replying later. On Tue, 5 Sep 2023 09:52:51 +0800 "wuqiang.matt" wrote: > The object pool is a scalable implementaion of high performance queue > for object allocation and reclamation, such as kretprobe instances. > > With leveraging percpu ring-array to mitigate the hot