Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Thu, Sep 1, 2016 at 6:56 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> I have a few patches that introduce SOC_DAPM_DOUBLE, so you can share a >> control between left/right channels. IMHO it makes the userspace mixer >> less confusing. > > I definitely agree that

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Thu, Sep 1, 2016 at 6:56 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> I have a few patches that introduce SOC_DAPM_DOUBLE, so you can share a >> control between left/right channels. IMHO it makes the userspace mixer >> less confusing. > > I definitely agree that cutting down on the number

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi Chen-Yu, > I have a few patches that introduce SOC_DAPM_DOUBLE, so you can share a > control between left/right channels. IMHO it makes the userspace mixer > less confusing. I definitely agree that cutting down on the number of sliders would be good. I do a double-take every time I open

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi Chen-Yu, > I have a few patches that introduce SOC_DAPM_DOUBLE, so you can share a > control between left/right channels. IMHO it makes the userspace mixer > less confusing. I definitely agree that cutting down on the number of sliders would be good. I do a double-take every time I open

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Wed, Aug 31, 2016 at 3:49 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> My apologies. I didn't notice that VMIC was already in the driver. >> In that your original patch did everything right. > > Don't worry about it :) > > But I have a question: > > If I replace

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Wed, Aug 31, 2016 at 3:49 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> My apologies. I didn't notice that VMIC was already in the driver. >> In that your original patch did everything right. > > Don't worry about it :) > > But I have a question: > > If I replace DAPM_INPUT by DAPM_MIC it

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi Chen-Yu, > My apologies. I didn't notice that VMIC was already in the driver. > In that your original patch did everything right. Don't worry about it :) But I have a question: If I replace DAPM_INPUT by DAPM_MIC it wants a callback that is supposed to fiddle with the bias. Do I provide

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi Chen-Yu, > My apologies. I didn't notice that VMIC was already in the driver. > In that your original patch did everything right. Don't worry about it :) But I have a question: If I replace DAPM_INPUT by DAPM_MIC it wants a callback that is supposed to fiddle with the bias. Do I provide

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Wed, Aug 31, 2016 at 3:17 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> > +static const char * const sun4i_codec_difflinein_capture_source[] = { >> > + "Non-Differential", >> > + "Differential", >> >> How about "Stereo"? And possibly "Mono Differential"?

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Wed, Aug 31, 2016 at 3:17 PM, Danny Milosavljevic wrote: > Hi Chen-Yu, > >> > +static const char * const sun4i_codec_difflinein_capture_source[] = { >> > + "Non-Differential", >> > + "Differential", >> >> How about "Stereo"? And possibly "Mono Differential"? or just "Mono". > >> A

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Wed, Aug 31, 2016 at 3:40 PM, Danny Milosavljevic wrote: >> And what about microphone bias? > > Would this be OK? > > static int sun4i_codec_handle_mic_bias_event(struct snd_soc_dapm_widget *w, > struct snd_kcontrol *k, int

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On Wed, Aug 31, 2016 at 3:40 PM, Danny Milosavljevic wrote: >> And what about microphone bias? > > Would this be OK? > > static int sun4i_codec_handle_mic_bias_event(struct snd_soc_dapm_widget *w, > struct snd_kcontrol *k, int > event) > { >

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

> And what about microphone bias? Would this be OK? static int sun4i_codec_handle_mic_bias_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *k, int event) { struct sun4i_codec *scodec = snd_soc_card_get_drvdata(w->dapm->card);

Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

> And what about microphone bias? Would this be OK? static int sun4i_codec_handle_mic_bias_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *k, int event) { struct sun4i_codec *scodec = snd_soc_card_get_drvdata(w->dapm->card);

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi Chen-Yu, > > +static const char * const sun4i_codec_difflinein_capture_source[] = { > > + "Non-Differential", > > + "Differential", > > How about "Stereo"? And possibly "Mono Differential"? or just "Mono". > A differential input can be used single-ended by grounding one side.

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi Chen-Yu, > > +static const char * const sun4i_codec_difflinein_capture_source[] = { > > + "Non-Differential", > > + "Differential", > > How about "Stereo"? And possibly "Mono Differential"? or just "Mono". > A differential input can be used single-ended by grounding one side.

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi, On Tue, Aug 30, 2016 at 1:44 PM, Danny Milosavljevic wrote: > Note: Mic1 Capture Volume is in a different register on A20 than on A10. > Note: Mic2 Capture Volume is in a different register on A20 than on A10. The subject would be better saying "Add support for

Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi, On Tue, Aug 30, 2016 at 1:44 PM, Danny Milosavljevic wrote: > Note: Mic1 Capture Volume is in a different register on A20 than on A10. > Note: Mic2 Capture Volume is in a different register on A20 than on A10. The subject would be better saying "Add support for Line-In, FM-In, Mic 2 and

Re: [linux-sunxi] [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi CK, On Tue, 30 Aug 2016 08:49:40 +0200 Code Kipper wrote: > On 29 August 2016 at 20:03, Danny Milosavljevic > wrote: > I think this should be delivered in a series of patches like what I've > attempted to do here >

Re: [linux-sunxi] [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Hi CK, On Tue, 30 Aug 2016 08:49:40 +0200 Code Kipper wrote: > On 29 August 2016 at 20:03, Danny Milosavljevic > wrote: > I think this should be delivered in a series of patches like what I've > attempted to do here > https://github.com/codekipper/linux-sunxi/commits/sunxi-wip?page=2 Feel

Re: [linux-sunxi] [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On 29 August 2016 at 20:03, Danny Milosavljevic wrote: > > Note: Mic1 Capture Volume is in a different register on A20 than on A10. > Note: Mic2 Capture Volume is in a different register on A20 than on A10. > --- > sound/soc/sunxi/sun4i-codec.c | 256 >

Re: [linux-sunxi] [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

On 29 August 2016 at 20:03, Danny Milosavljevic wrote: > > Note: Mic1 Capture Volume is in a different register on A20 than on A10. > Note: Mic2 Capture Volume is in a different register on A20 than on A10. > --- > sound/soc/sunxi/sun4i-codec.c | 256 > ++

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git

[PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

Note: Mic1 Capture Volume is in a different register on A20 than on A10. Note: Mic2 Capture Volume is in a different register on A20 than on A10. --- sound/soc/sunxi/sun4i-codec.c | 256 ++ 1 file changed, 236 insertions(+), 20 deletions(-) diff --git