Re: [PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s

2020-11-09 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 07:26:04PM -0500, Joel Fernandes wrote: > On Wed, Nov 04, 2020 at 07:57:13PM -0800, Paul E. McKenney wrote: > > On Tue, Nov 03, 2020 at 09:26:02AM -0500, Joel Fernandes (Google) wrote: > > > This memory barrier is not needed as rcu_segcblist_add_len() already > > > includes

Re: [PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s

2020-11-06 Thread Joel Fernandes
On Wed, Nov 04, 2020 at 07:57:13PM -0800, Paul E. McKenney wrote: > On Tue, Nov 03, 2020 at 09:26:02AM -0500, Joel Fernandes (Google) wrote: > > This memory barrier is not needed as rcu_segcblist_add_len() already > > includes a memory barrier *before* and *after* the length of the list is > >

Re: [PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s

2020-11-04 Thread Paul E. McKenney
On Tue, Nov 03, 2020 at 09:26:02AM -0500, Joel Fernandes (Google) wrote: > This memory barrier is not needed as rcu_segcblist_add_len() already > includes a memory barrier *before* and *after* the length of the list is > updated. > > Same reasoning for rcu_segcblist_enqueue(). I suggest a commit

[PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s

2020-11-03 Thread Joel Fernandes (Google)
This memory barrier is not needed as rcu_segcblist_add_len() already includes a memory barrier *before* and *after* the length of the list is updated. Same reasoning for rcu_segcblist_enqueue(). Reviewed-by: Frederic Weisbecker Signed-off-by: Joel Fernandes (Google) ---