Re: [PATCH v9 7/7] rcu/segcblist: Add additional comments to explain smp_mb()

2020-11-09 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 05:41:41PM -0500, Joel Fernandes wrote: > On Thu, Nov 05, 2020 at 10:55:51AM -0800, Paul E. McKenney wrote: > > On Tue, Nov 03, 2020 at 09:26:03AM -0500, Joel Fernandes (Google) wrote: > > > Memory barriers are needed when updating the full length of the > > > segcblist, how

Re: [PATCH v9 7/7] rcu/segcblist: Add additional comments to explain smp_mb()

2020-11-06 Thread Joel Fernandes
On Thu, Nov 05, 2020 at 10:55:51AM -0800, Paul E. McKenney wrote: > On Tue, Nov 03, 2020 at 09:26:03AM -0500, Joel Fernandes (Google) wrote: > > Memory barriers are needed when updating the full length of the > > segcblist, however it is not fully clearly why one is needed before and > > after. Thi

Re: [PATCH v9 7/7] rcu/segcblist: Add additional comments to explain smp_mb()

2020-11-05 Thread Paul E. McKenney
On Tue, Nov 03, 2020 at 09:26:03AM -0500, Joel Fernandes (Google) wrote: > Memory barriers are needed when updating the full length of the > segcblist, however it is not fully clearly why one is needed before and > after. This patch therefore adds additional comments to the function > header to exp

[PATCH v9 7/7] rcu/segcblist: Add additional comments to explain smp_mb()

2020-11-03 Thread Joel Fernandes (Google)
Memory barriers are needed when updating the full length of the segcblist, however it is not fully clearly why one is needed before and after. This patch therefore adds additional comments to the function header to explain it. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu_segcblist.c