Re: [PATCH wireless/arlan] Replace logical- by bit-and

Randy Dunlap wrote: > On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > >> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h >> index 3ed1df7..7b7498f 100644 >> --- a/drivers/net/wireless/arlan.h >> +++ b/drivers/net/wireless/arlan.h >> @@ -485,7 +485,7 @@ struct

Re: [PATCH wireless/arlan] Replace logical- by bit-and

On Thu, Jan 10, 2008 at 01:16:33PM -0800, Randy Dunlap wrote: > Chuck Ebbert wrote: >> On 01/10/2008 03:28 PM, Randy Dunlap wrote: > >>> >>> 0x80 && 0x40 -> 0 >> >> 1 > > duh. ack. Well it still seems wrong, changing from an "| 1" to an "| 0". Anyone still using Arlan that can verify the proper

Re: [PATCH wireless/arlan] Replace logical- by bit-and

Chuck Ebbert wrote: On 01/10/2008 03:28 PM, Randy Dunlap wrote: 0x80 && 0x40 -> 0 1 duh. ack. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH wireless/arlan] Replace logical- by bit-and

On 01/10/2008 03:28 PM, Randy Dunlap wrote: > On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > >> Totally untested patch below from linus' git tree. The && is incorrect, >> right? >> >> from drivers/net/wireless/arlan.h:390: >> #define ARLAN_POWER 0x40 >> #define ARLAN_ACCESS

Re: [PATCH wireless/arlan] Replace logical- by bit-and

On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > Totally untested patch below from linus' git tree. The && is incorrect, right? > > from drivers/net/wireless/arlan.h:390: > #define ARLAN_POWER 0x40 > #define ARLAN_ACCESS0x80 > > Replace logical and by bit-and > >

[PATCH wireless/arlan] Replace logical- by bit-and

Totally untested patch below from linus' git tree. The && is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80 Replace logical and by bit-and Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git

[PATCH wireless/arlan] Replace logical- by bit-and

Totally untested patch below from linus' git tree. The is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80 Replace logical and by bit-and Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git

Re: [PATCH wireless/arlan] Replace logical- by bit-and

On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: Totally untested patch below from linus' git tree. The is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80 Replace logical and by bit-and

Re: [PATCH wireless/arlan] Replace logical- by bit-and

On 01/10/2008 03:28 PM, Randy Dunlap wrote: On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: Totally untested patch below from linus' git tree. The is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80

Re: [PATCH wireless/arlan] Replace logical- by bit-and

Chuck Ebbert wrote: On 01/10/2008 03:28 PM, Randy Dunlap wrote: 0x80 0x40 - 0 1 duh. ack. -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH wireless/arlan] Replace logical- by bit-and

On Thu, Jan 10, 2008 at 01:16:33PM -0800, Randy Dunlap wrote: Chuck Ebbert wrote: On 01/10/2008 03:28 PM, Randy Dunlap wrote: 0x80 0x40 - 0 1 duh. ack. Well it still seems wrong, changing from an | 1 to an | 0. Anyone still using Arlan that can verify the proper fix (which I'd guess is

Re: [PATCH wireless/arlan] Replace logical- by bit-and

Randy Dunlap wrote: On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h index 3ed1df7..7b7498f 100644 --- a/drivers/net/wireless/arlan.h +++ b/drivers/net/wireless/arlan.h @@ -485,7 +485,7 @@ struct arlan_private {