Re: [PATCH workqueue/for-3.18-fixes 1/2] workqueue: invert the order between pool->lock and wq_mayday_lock

2014-12-04 Thread Lai Jiangshan
On 12/04/2014 11:11 PM, Tejun Heo wrote: > Currently, pool->lock nests inside pool->lock. There's no inherent > reason for this order. The only place where the two locks are held > together is pool_mayday_timeout() and it just got decided that way. > > This nesting order turns out to complicate

[PATCH workqueue/for-3.18-fixes 1/2] workqueue: invert the order between pool->lock and wq_mayday_lock

2014-12-04 Thread Tejun Heo
Currently, pool->lock nests inside pool->lock. There's no inherent reason for this order. The only place where the two locks are held together is pool_mayday_timeout() and it just got decided that way. This nesting order turns out to complicate things with the planned rescuer_thread() update. L