Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-30 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 10:33:06 -0400 > The problem is that users have to wait tens of minutes to see perf > top results on the screen in KNL. Before that, there is nothing but > a black screen. I'm actually curious why so I started digging last night. First, I made perf top

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Liang, Kan
On 10/29/2018 6:42 PM, David Miller wrote: From: "Liang, Kan" Date: Mon, 29 Oct 2018 18:32:40 -0400 - struct annotation_options *annotation_options __maybe_unused) + struct annotation_options *annotation_options __maybe_unused, +

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 18:32:40 -0400 > - struct annotation_options *annotation_options > __maybe_unused) > + struct annotation_options *annotation_options __maybe_unused, > + atomic_t *nr_rb_read __maybe_unused) > {

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Liang, Kan
There is no problem with the message, the problem is the thread where the message is being displayed, just signal the display thread to display the warning, not doing that in the event processing thread. How about this patch (just did some simple test)? It moves the warning to display thr

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 14:20:15 -0400 > You didn't see any warning before the patch. I think it is just > because perf top hides the problem. Quite honestly, the last time I played around with this: 1) The new ring buffer mode didn't exist 2) perf started up much more quickl

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 29, 2018 at 02:20:15PM -0400, Liang, Kan escreveu: > > > On 10/29/2018 1:48 PM, David Miller wrote: > > From: "Liang, Kan" > > Date: Mon, 29 Oct 2018 13:42:56 -0400 > > > > > > > > > > > On 10/29/2018 1:40 PM, David Miller wrote: > > > > From: "Liang, Kan" > > > > Date: Mon, 29 O

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Liang, Kan
On 10/29/2018 1:48 PM, David Miller wrote: From: "Liang, Kan" Date: Mon, 29 Oct 2018 13:42:56 -0400 On 10/29/2018 1:40 PM, David Miller wrote: From: "Liang, Kan" Date: Mon, 29 Oct 2018 10:33:06 -0400 I just realized that the problem in KNL will be back if we switch back to non-overwri

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 29, 2018 at 10:43:21AM -0700, David Miller escreveu: > From: "Liang, Kan" > Date: Mon, 29 Oct 2018 11:11:25 -0400 > > > The processing time for each perf_top__mmap_read_idx() should not that > > long. We may check it after each perf_top__mmap_read_idx(). Also > > change the ui_warning

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 29, 2018 at 10:40:08AM -0700, David Miller escreveu: > From: "Liang, Kan" > Date: Mon, 29 Oct 2018 10:33:06 -0400 > > > I just realized that the problem in KNL will be back if we switch > > back to non-overwrite mode. > >> What is KNL? I guess its Knights Landing. https://en.wikipe

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 13:42:56 -0400 > > > On 10/29/2018 1:40 PM, David Miller wrote: >> From: "Liang, Kan" >> Date: Mon, 29 Oct 2018 10:33:06 -0400 >> >>> I just realized that the problem in KNL will be back if we switch >>> back to non-overwrite mode. >> What is KNL? >>

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 11:11:25 -0400 > The processing time for each perf_top__mmap_read_idx() should not that > long. We may check it after each perf_top__mmap_read_idx(). Also > change the ui_warning to one-time warning. The patch as below can do > that (not test). You canno

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Liang, Kan
On 10/29/2018 1:40 PM, David Miller wrote: From: "Liang, Kan" Date: Mon, 29 Oct 2018 10:33:06 -0400 I just realized that the problem in KNL will be back if we switch back to non-overwrite mode. What is KNL? Intel Xeon Phi Processor, Knights Landing. Thanks, Kan

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 10:33:06 -0400 > I just realized that the problem in KNL will be back if we switch > back to non-overwrite mode. What is KNL?

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Liang, Kan
On 10/29/2018 10:35 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Oct 29, 2018 at 10:33:06AM -0400, Liang, Kan escreveu: On 10/29/2018 9:03 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Oct 26, 2018 at 04:11:51PM -0400, Liang, Kan escreveu: On 10/26/2018 3:24 PM, Arnaldo Carvalho de Melo wrote:

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 29, 2018 at 10:33:06AM -0400, Liang, Kan escreveu: > On 10/29/2018 9:03 AM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 26, 2018 at 04:11:51PM -0400, Liang, Kan escreveu: > > > On 10/26/2018 3:24 PM, Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Oct 26, 2018 at 03:16:29PM -0400, L

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Liang, Kan
On 10/29/2018 9:03 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Oct 26, 2018 at 04:11:51PM -0400, Liang, Kan escreveu: On 10/26/2018 3:24 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Oct 26, 2018 at 03:16:29PM -0400, Liang, Kan escreveu: On 10/26/2018 3:12 PM, Arnaldo Carvalho de Melo wrote:

[PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 26, 2018 at 04:11:51PM -0400, Liang, Kan escreveu: > On 10/26/2018 3:24 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 26, 2018 at 03:16:29PM -0400, Liang, Kan escreveu: > > > On 10/26/2018 3:12 PM, Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Oct 26, 2018 at 03:07:40PM -0400, L