Re: [PATCHSET] cgroup: simplify cgroup removal path

2012-10-31 Thread Glauber Costa
On 10/31/2012 09:26 PM, Tejun Heo wrote: > On Wed, Oct 31, 2012 at 09:24:06PM +0400, Glauber Costa wrote: >>> Note both in the commit messages. >> >> I am sorry, but I can't find anything that may be related to this in the >> commit messages. Can you be more specific ? > > Eh.. 'd', missing there.

Re: [PATCHSET] cgroup: simplify cgroup removal path

2012-10-31 Thread Tejun Heo
On Wed, Oct 31, 2012 at 09:24:06PM +0400, Glauber Costa wrote: > > Note both in the commit messages. > > I am sorry, but I can't find anything that may be related to this in the > commit messages. Can you be more specific ? Eh.. 'd', missing there. I meant that I noted both in the updated commit

Re: [PATCHSET] cgroup: simplify cgroup removal path

2012-10-31 Thread Glauber Costa
On 10/31/2012 09:18 PM, Tejun Heo wrote: > Hello, > > On Wed, Oct 31, 2012 at 05:49:33PM +0400, Glauber Costa wrote: >> The only think that drew my attention is that you are changing the >> local_irq_save callsite to local_irq_disable. It shouldn't be a problem, >> since this is never expected to

Re: [PATCHSET] cgroup: simplify cgroup removal path

2012-10-31 Thread Tejun Heo
Hello, On Wed, Oct 31, 2012 at 05:49:33PM +0400, Glauber Costa wrote: > The only think that drew my attention is that you are changing the > local_irq_save callsite to local_irq_disable. It shouldn't be a problem, > since this is never expected to be called in interrupt context. > > Still... it m

Re: [PATCHSET] cgroup: simplify cgroup removal path

2012-10-31 Thread Tejun Heo
On Wed, Oct 31, 2012 at 05:31:34PM +0100, Michal Hocko wrote: > Thanks for this cleanup. The code looks much better now and: > $ git diff --stat mmotm...tj-cgroups/review-cgroup-rmdir-updates > block/blk-cgroup.c |3 +- > include/linux/cgroup.h | 41 +--- > kernel/cgroup.c|

Re: [PATCHSET] cgroup: simplify cgroup removal path

2012-10-31 Thread Michal Hocko
Thanks for this cleanup. The code looks much better now and: $ git diff --stat mmotm...tj-cgroups/review-cgroup-rmdir-updates block/blk-cgroup.c |3 +- include/linux/cgroup.h | 41 +--- kernel/cgroup.c| 256 mm/hugetlb_cgroup.

Re: [PATCHSET] cgroup: simplify cgroup removal path

2012-10-31 Thread Glauber Costa
On 10/31/2012 08:22 AM, Tejun Heo wrote: > Hello, guys. > > cgroup removal path is quite ugly. A lot of the ugliness comes from > the weird design which allows ->pre_destroy() to fail and the feature > to drain existing CSS reference counts before committing to removal. > Both mean that it should

[PATCHSET] cgroup: simplify cgroup removal path

2012-10-30 Thread Tejun Heo
Hello, guys. cgroup removal path is quite ugly. A lot of the ugliness comes from the weird design which allows ->pre_destroy() to fail and the feature to drain existing CSS reference counts before committing to removal. Both mean that it should be possible to roll-back cgroup destruction after so