Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-22 Thread Tejun Heo
Jan Engelhardt wrote: > On Jan 23 2008 08:51, Tejun Heo wrote: >> What do you think about the second suggestion then? >> >> ata1.00: line0 >> ata1.00 line1 >> ata1.00 line2 >> >> It allows you to grab for the header && has indication for message >> boundaries. > > Then again, why not "[ata1.00]

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-22 Thread Jan Engelhardt
On Jan 23 2008 08:51, Tejun Heo wrote: > >What do you think about the second suggestion then? > >ata1.00: line0 >ata1.00 line1 >ata1.00 line2 > >It allows you to grab for the header && has indication for message >boundaries. Then again, why not "[ata1.00] line0", then it matches what sd_mod doe

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-22 Thread Tejun Heo
Jan Engelhardt wrote: > On Jan 21 2008 05:48, Matthew Wilcox wrote: >> On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote: >>> In a nutshell, printk_header() lets you do the following atomically >>> (against other messages). >>> >>> code: >>> printk(KERN_INFO "ata1.00: ", "line0\nline1\nl

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-22 Thread Jan Engelhardt
On Jan 21 2008 05:48, Matthew Wilcox wrote: >On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote: >> In a nutshell, printk_header() lets you do the following atomically >> (against other messages). >> >> code: >> printk(KERN_INFO "ata1.00: ", "line0\nline1\nline2\n"); >> >> output: >>

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-21 Thread Tejun Heo
Matthew Wilcox wrote: > On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote: >> In a nutshell, printk_header() lets you do the following atomically >> (against other messages). >> >> code: >> printk(KERN_INFO "ata1.00: ", "line0\nline1\nline2\n"); >> >> output: >> <6>ata1.00: line0 >>

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-21 Thread Matthew Wilcox
On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote: > In a nutshell, printk_header() lets you do the following atomically > (against other messages). > > code: > printk(KERN_INFO "ata1.00: ", "line0\nline1\nline2\n"); > > output: > <6>ata1.00: line0 > <6> line1 > <6>

[PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-20 Thread Tejun Heo
Hello, all. This is the second take of implement-printk_header-and-mprintk patchset. Changes from the last take[L] are... * s/mprintk_push/mprintk_add/ and other changes suggested by Randy Dunlap. * mp->buf instead of mp->header to ease freeing kmalloc'd buffer later. * mprintk