Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-09 Thread Don Zickus
On Fri, May 09, 2014 at 03:11:28PM +0900, Namhyung Kim wrote: > >> > I am willing to believe I missed scenario when sorting, I just can't > >> > think > >> > of it (so I wouldn't know how to fix it). That's why I was looking for > >> > an > >> > example to make it more obvious to me. Sorry for

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-09 Thread Namhyung Kim
Hi Don, On Wed, 7 May 2014 11:22:19 -0400, Don Zickus wrote: > On Wed, May 07, 2014 at 12:05:58PM +0900, Namhyung Kim wrote: >> Hi Don, >> >> On Wed, 30 Apr 2014 09:35:55 -0400, Don Zickus wrote: >> > On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: >> >> Hi Don, >> >> >> >> On

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-09 Thread Namhyung Kim
Hi Don, On Wed, 7 May 2014 11:22:19 -0400, Don Zickus wrote: On Wed, May 07, 2014 at 12:05:58PM +0900, Namhyung Kim wrote: Hi Don, On Wed, 30 Apr 2014 09:35:55 -0400, Don Zickus wrote: On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: Hi Don, On Tue, 29 Apr 2014 13:27:35

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-09 Thread Don Zickus
On Fri, May 09, 2014 at 03:11:28PM +0900, Namhyung Kim wrote: I am willing to believe I missed scenario when sorting, I just can't think of it (so I wouldn't know how to fix it). That's why I was looking for an example to make it more obvious to me. Sorry for being slow..

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-07 Thread Don Zickus
On Wed, May 07, 2014 at 12:05:58PM +0900, Namhyung Kim wrote: > Hi Don, > > On Wed, 30 Apr 2014 09:35:55 -0400, Don Zickus wrote: > > On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: > >> Hi Don, > >> > >> On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: > >> > On Tue, Apr 29,

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-07 Thread Don Zickus
On Wed, May 07, 2014 at 12:05:58PM +0900, Namhyung Kim wrote: Hi Don, On Wed, 30 Apr 2014 09:35:55 -0400, Don Zickus wrote: On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: Hi Don, On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: On Tue, Apr 29, 2014 at 10:13:35AM

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-06 Thread Namhyung Kim
Hi Jiri, On Sun, 4 May 2014 19:53:34 +0200, Jiri Olsa wrote: > On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: > > SNIP > >> >> * changes in v4: >> - fix a tui navigation bug >> - fix a bug in output change of perf diff >> - move call to perf_hpp__init() out of

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-06 Thread Namhyung Kim
Hi Don, On Wed, 30 Apr 2014 09:35:55 -0400, Don Zickus wrote: > On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: >> Hi Don, >> >> On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: >> > On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: >> >> >/* >> >> >

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-06 Thread Namhyung Kim
Hi Don, On Wed, 30 Apr 2014 09:35:55 -0400, Don Zickus wrote: On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: Hi Don, On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: /* * Addresses with

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-06 Thread Namhyung Kim
Hi Jiri, On Sun, 4 May 2014 19:53:34 +0200, Jiri Olsa wrote: On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: SNIP * changes in v4: - fix a tui navigation bug - fix a bug in output change of perf diff - move call to perf_hpp__init() out of setup_browser() - fix

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-04 Thread Jiri Olsa
On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: SNIP > > * changes in v4: > - fix a tui navigation bug > - fix a bug in output change of perf diff > - move call to perf_hpp__init() out of setup_browser() > - fix alignment of some output fields on stdio > > * changes in

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-05-04 Thread Jiri Olsa
On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: SNIP * changes in v4: - fix a tui navigation bug - fix a bug in output change of perf diff - move call to perf_hpp__init() out of setup_browser() - fix alignment of some output fields on stdio * changes in v3: -

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-30 Thread Don Zickus
On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: > Hi Don, > > On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: > > On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: > >> >/* > >> > * Addresses with no major/minor numbers are assumed to be > >> >

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-30 Thread Don Zickus
On Wed, Apr 30, 2014 at 08:38:10AM +0900, Namhyung Kim wrote: Hi Don, On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: /* * Addresses with no major/minor numbers are assumed to be * anonymous

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-29 Thread Namhyung Kim
Hi Don, On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: > On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: >> >/* >> > * Addresses with no major/minor numbers are assumed to be >> > * anonymous in userspace. Sort those on pid then address. >> >

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-29 Thread Don Zickus
On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: > > Our orignal concept for the c2c tool was to sort hist entries into > > cachelines, filter in only the HITMs and stores and re-sort based on > > cachelines with the most weight. > > > > So using today's perf with a new search called

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-29 Thread Don Zickus
On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: Our orignal concept for the c2c tool was to sort hist entries into cachelines, filter in only the HITMs and stores and re-sort based on cachelines with the most weight. So using today's perf with a new search called

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-29 Thread Namhyung Kim
Hi Don, On Tue, 29 Apr 2014 13:27:35 -0400, Don Zickus wrote: On Tue, Apr 29, 2014 at 10:13:35AM +0900, Namhyung Kim wrote: /* * Addresses with no major/minor numbers are assumed to be * anonymous in userspace. Sort those on pid then address. * *

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-28 Thread Namhyung Kim
Hi Don, On Mon, 28 Apr 2014 15:46:42 -0400, Don Zickus wrote: > On Thu, Apr 24, 2014 at 05:00:15PM -0400, Don Zickus wrote: >> On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: >> > Hi Don, >> > >> > 2014-04-23 (수), 08:58 -0400, Don Zickus: >> > > On Wed, Apr 23, 2014 at 03:15:35PM

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-28 Thread Don Zickus
On Thu, Apr 24, 2014 at 05:00:15PM -0400, Don Zickus wrote: > On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: > > Hi Don, > > > > 2014-04-23 (수), 08:58 -0400, Don Zickus: > > > On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: > > > > On Tue, 22 Apr 2014 17:16:47 -0400,

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-28 Thread Don Zickus
On Thu, Apr 24, 2014 at 05:00:15PM -0400, Don Zickus wrote: On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: Hi Don, 2014-04-23 (수), 08:58 -0400, Don Zickus: On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-28 Thread Namhyung Kim
Hi Don, On Mon, 28 Apr 2014 15:46:42 -0400, Don Zickus wrote: On Thu, Apr 24, 2014 at 05:00:15PM -0400, Don Zickus wrote: On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: Hi Don, 2014-04-23 (수), 08:58 -0400, Don Zickus: On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-25 Thread Namhyung Kim
Hi Don, On Thu, 24 Apr 2014 17:00:15 -0400, Don Zickus wrote: > On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: >> Hmm.. it seems that it's exactly sorted by the data symbol addresses, so >> I don't see any problem here. What did you expect? If you want to see >> those

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-25 Thread Namhyung Kim
Hi Don, On Thu, 24 Apr 2014 17:00:15 -0400, Don Zickus wrote: On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: Hmm.. it seems that it's exactly sorted by the data symbol addresses, so I don't see any problem here. What did you expect? If you want to see those symbol_daddr,pid

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-24 Thread Don Zickus
On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: > Hi Don, > > 2014-04-23 (수), 08:58 -0400, Don Zickus: > > On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: > > > On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: > > > > ./perf mem record -a grep -r foo /* >

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-24 Thread Namhyung Kim
Hi Don, 2014-04-23 (수), 08:58 -0400, Don Zickus: > On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: > > On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: > > > ./perf mem record -a grep -r foo /* > /dev/null > > > ./perf mem report -F overhead,symbol_daddr,pid -s symbol_daddr,pid

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-24 Thread Namhyung Kim
Hi Don, 2014-04-23 (수), 08:58 -0400, Don Zickus: On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: ./perf mem record -a grep -r foo /* /dev/null ./perf mem report -F overhead,symbol_daddr,pid -s symbol_daddr,pid

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-24 Thread Don Zickus
On Thu, Apr 24, 2014 at 10:41:39PM +0900, Namhyung Kim wrote: Hi Don, 2014-04-23 (수), 08:58 -0400, Don Zickus: On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: ./perf mem record -a grep -r foo /* /dev/null ./perf

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-23 Thread Don Zickus
On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: > Hi Don, > > On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: > > On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: > >> Hello, > >> > >> This is a patchset implementing -F/--fields option to setup output > >>

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-23 Thread Namhyung Kim
Hi Don, On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: > On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: >> Hello, >> >> This is a patchset implementing -F/--fields option to setup output >> field/column as Ingo requested. It depends on my --percentage >> patchset [1]. >>

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-23 Thread Namhyung Kim
Hi Don, On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: Hello, This is a patchset implementing -F/--fields option to setup output field/column as Ingo requested. It depends on my --percentage patchset [1]. The -F

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-23 Thread Don Zickus
On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote: Hi Don, On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote: On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: Hello, This is a patchset implementing -F/--fields option to setup output field/column as Ingo

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-22 Thread Don Zickus
On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: > Hello, > > This is a patchset implementing -F/--fields option to setup output > field/column as Ingo requested. It depends on my --percentage > patchset [1]. > > The -F option can receive any sort keys that -s option recognize,

Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-22 Thread Don Zickus
On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote: Hello, This is a patchset implementing -F/--fields option to setup output field/column as Ingo requested. It depends on my --percentage patchset [1]. The -F option can receive any sort keys that -s option recognize, plus

[PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-15 Thread Namhyung Kim
Hello, This is a patchset implementing -F/--fields option to setup output field/column as Ingo requested. It depends on my --percentage patchset [1]. The -F option can receive any sort keys that -s option recognize, plus following fields (name can be changed): overhead, overhead_sys,

[PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

2014-04-15 Thread Namhyung Kim
Hello, This is a patchset implementing -F/--fields option to setup output field/column as Ingo requested. It depends on my --percentage patchset [1]. The -F option can receive any sort keys that -s option recognize, plus following fields (name can be changed): overhead, overhead_sys,