Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-10 Thread Andrew Morton
On Thu, 11 Jan 2007 08:43:36 +0530 Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > The s/lock_page_slow/lock_page_blocking/ got lost. I redid it. > > I thought the lock_page_blocking was an alternative you had suggested > to the __lock_page vs lock_page_async discussion which got resolved

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-10 Thread Suparna Bhattacharya
On Wed, Jan 10, 2007 at 05:08:29PM -0800, Andrew Morton wrote: > On Wed, 10 Jan 2007 11:14:19 +0530 > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: > > > On Thu, 4 Jan 2007 10:26:21 +0530 > > > Suparna Bhattacharya <[EMAIL

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-10 Thread Andrew Morton
On Wed, 10 Jan 2007 11:14:19 +0530 Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: > > On Thu, 4 Jan 2007 10:26:21 +0530 > > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > > > On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-10 Thread Andrew Morton
On Wed, 10 Jan 2007 11:14:19 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote:

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-10 Thread Suparna Bhattacharya
On Wed, Jan 10, 2007 at 05:08:29PM -0800, Andrew Morton wrote: On Wed, 10 Jan 2007 11:14:19 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote:

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-10 Thread Andrew Morton
On Thu, 11 Jan 2007 08:43:36 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: The s/lock_page_slow/lock_page_blocking/ got lost. I redid it. I thought the lock_page_blocking was an alternative you had suggested to the __lock_page vs lock_page_async discussion which got resolved later.

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-09 Thread Suparna Bhattacharya
On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: > On Thu, 4 Jan 2007 10:26:21 +0530 > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: > > Patches against next -mm would be appreciated, please. Sorry about that.

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-09 Thread Suparna Bhattacharya
On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: Patches against next -mm would be appreciated, please. Sorry about that. I have

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-05 Thread Jens Axboe
On Fri, Jan 05 2007, Suparna Bhattacharya wrote: > On Fri, Jan 05, 2007 at 08:02:33AM +0100, Jens Axboe wrote: > > On Fri, Jan 05 2007, Suparna Bhattacharya wrote: > > > On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: > > > > On Thu, 4 Jan 2007 10:26:21 +0530 > > > > Suparna

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-05 Thread Suparna Bhattacharya
On Fri, Jan 05, 2007 at 08:02:33AM +0100, Jens Axboe wrote: > On Fri, Jan 05 2007, Suparna Bhattacharya wrote: > > On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: > > > On Thu, 4 Jan 2007 10:26:21 +0530 > > > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > > > > > On Wed, Jan

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-05 Thread Suparna Bhattacharya
On Fri, Jan 05, 2007 at 08:02:33AM +0100, Jens Axboe wrote: On Fri, Jan 05 2007, Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Wed, Jan 03, 2007 at

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-05 Thread Jens Axboe
On Fri, Jan 05 2007, Suparna Bhattacharya wrote: On Fri, Jan 05, 2007 at 08:02:33AM +0100, Jens Axboe wrote: On Fri, Jan 05 2007, Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Jens Axboe
On Fri, Jan 05 2007, Suparna Bhattacharya wrote: > On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: > > On Thu, 4 Jan 2007 10:26:21 +0530 > > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > > > On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: > > > > On Thu, 28

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Suparna Bhattacharya
On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: > On Thu, 4 Jan 2007 10:26:21 +0530 > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: > > > On Thu, 28 Dec 2006 13:53:08 +0530 > > > Suparna Bhattacharya <[EMAIL

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Nick Piggin
Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 05:50:11PM +1100, Nick Piggin wrote: OK, but I think that after IO submission, you do not run sync_page to unplug the block device, like the normal IO path would (via lock_page, before the explicit plug patches). In the buffered AIO case,

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Jens Axboe
On Thu, Jan 04 2007, Andrew Morton wrote: > > Please let know how you want this fixed up. > > > > >From what I can tell the comments in the unplug patches seem to say that > > it needs more work and testing, so perhaps a separate fixup patch may be > > a better idea rather than make the fsaio

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Andrew Morton
On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: > > On Thu, 28 Dec 2006 13:53:08 +0530 > > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > > > This patchset implements changes to make

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Suparna Bhattacharya
On Thu, Jan 04, 2007 at 05:50:11PM +1100, Nick Piggin wrote: > Suparna Bhattacharya wrote: > >On Thu, Jan 04, 2007 at 04:51:58PM +1100, Nick Piggin wrote: > > >>So long as AIO threads do the same, there would be no problem (plugging > >>is optional, of course). > > > > > >Yup, the AIO threads run

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Suparna Bhattacharya
On Thu, Jan 04, 2007 at 05:50:11PM +1100, Nick Piggin wrote: Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 04:51:58PM +1100, Nick Piggin wrote: So long as AIO threads do the same, there would be no problem (plugging is optional, of course). Yup, the AIO threads run the same code

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Andrew Morton
On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: On Thu, 28 Dec 2006 13:53:08 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: This patchset implements changes to make filesystem AIO read

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Jens Axboe
On Thu, Jan 04 2007, Andrew Morton wrote: Please let know how you want this fixed up. From what I can tell the comments in the unplug patches seem to say that it needs more work and testing, so perhaps a separate fixup patch may be a better idea rather than make the fsaio patchset

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Nick Piggin
Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 05:50:11PM +1100, Nick Piggin wrote: OK, but I think that after IO submission, you do not run sync_page to unplug the block device, like the normal IO path would (via lock_page, before the explicit plug patches). In the buffered AIO case,

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Suparna Bhattacharya
On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: On Thu, 28 Dec 2006 13:53:08 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote:

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Jens Axboe
On Fri, Jan 05 2007, Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: On Thu, 28 Dec 2006 13:53:08

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Nick Piggin
Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 04:51:58PM +1100, Nick Piggin wrote: So long as AIO threads do the same, there would be no problem (plugging is optional, of course). Yup, the AIO threads run the same code as for regular IO, i.e in the rare situations where they actually

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Suparna Bhattacharya
On Thu, Jan 04, 2007 at 04:51:58PM +1100, Nick Piggin wrote: > Suparna Bhattacharya wrote: > >On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: > > >>Plus Jens's unplugging changes add more reliance upon context inside > >>*current, for the plugging and unplugging operations. I

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Nick Piggin
Suparna Bhattacharya wrote: On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: Plus Jens's unplugging changes add more reliance upon context inside *current, for the plugging and unplugging operations. I expect that the fsaio patches will need to be aware of the protocol which

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Suparna Bhattacharya
On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: > On Thu, 28 Dec 2006 13:53:08 +0530 > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > This patchset implements changes to make filesystem AIO read > > and write asynchronous for the non O_DIRECT case. > > Unfortunately the

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Andrew Morton
On Thu, 28 Dec 2006 13:53:08 +0530 Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > This patchset implements changes to make filesystem AIO read > and write asynchronous for the non O_DIRECT case. Unfortunately the unplugging changes in Jen's block tree have trashed these patches to a degree

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Andrew Morton
On Thu, 28 Dec 2006 13:53:08 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: This patchset implements changes to make filesystem AIO read and write asynchronous for the non O_DIRECT case. Unfortunately the unplugging changes in Jen's block tree have trashed these patches to a degree that

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Suparna Bhattacharya
On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: On Thu, 28 Dec 2006 13:53:08 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: This patchset implements changes to make filesystem AIO read and write asynchronous for the non O_DIRECT case. Unfortunately the unplugging

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-03 Thread Nick Piggin
Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 04:51:58PM +1100, Nick Piggin wrote: So long as AIO threads do the same, there would be no problem (plugging is optional, of course). Yup, the AIO threads run the same code as for regular IO, i.e in the rare situations where they actually

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2006-12-28 Thread Andrew Morton
On Thu, 28 Dec 2006 13:53:08 +0530 Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > This patchset implements changes to make filesystem AIO read > and write asynchronous for the non O_DIRECT case. I did s/lock_page_slow/lock_page_blocking/g then merged all these into -mm, thanks. - To

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2006-12-28 Thread Ingo Molnar
* Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > The following is a sampling of comparative aio-stress results with the > patches (each run starts with uncached files): > > - > > aio-stress throughput comparisons (in

[PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2006-12-28 Thread Suparna Bhattacharya
Currently native linux AIO is properly supported (in the sense of actually being asynchronous) only for files opened with O_DIRECT. While this suffices for a major (and most visible) user of AIO, i.e. databases, other types of users like Samba require AIO support for regular file IO. Also, for

[PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2006-12-28 Thread Suparna Bhattacharya
Currently native linux AIO is properly supported (in the sense of actually being asynchronous) only for files opened with O_DIRECT. While this suffices for a major (and most visible) user of AIO, i.e. databases, other types of users like Samba require AIO support for regular file IO. Also, for

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2006-12-28 Thread Ingo Molnar
* Suparna Bhattacharya [EMAIL PROTECTED] wrote: The following is a sampling of comparative aio-stress results with the patches (each run starts with uncached files): - aio-stress throughput comparisons (in MB/s):

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2006-12-28 Thread Andrew Morton
On Thu, 28 Dec 2006 13:53:08 +0530 Suparna Bhattacharya [EMAIL PROTECTED] wrote: This patchset implements changes to make filesystem AIO read and write asynchronous for the non O_DIRECT case. I did s/lock_page_slow/lock_page_blocking/g then merged all these into -mm, thanks. - To unsubscribe