Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-21 Thread Tejun Heo
Hello, Oleg. On Sun, Oct 21, 2012 at 09:18:53PM +0200, Oleg Nesterov wrote: > > I'm waiting for Oleg to poke some holes in the synchronization > > department but if that doesn't happen you can pull from the above > > branch. I'll pull it into cgroup/for-3.8 too. > > Just in case, I see nothing b

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-21 Thread Oleg Nesterov
On 10/19, Tejun Heo wrote: > > On Fri, Oct 19, 2012 at 06:54:42PM +0200, Rafael J. Wysocki wrote: > > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git > > > review-cgroup_freezer-locking > > > > It seems that no one has any comments. :-) > > > > Are you going to prepare a branch for

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-19 Thread Tejun Heo
On Fri, Oct 19, 2012 at 06:54:42PM +0200, Rafael J. Wysocki wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git > > review-cgroup_freezer-locking > > It seems that no one has any comments. :-) > > Are you going to prepare a branch for me to pull from? I'm waiting for Oleg to

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-19 Thread Tejun Heo
Hey, Matt. On Thu, Oct 18, 2012 at 06:29:45PM -0700, Matt Helsley wrote: > Yeah, that would be a nice cleanup too. I guess the ultra-careful way to > remove this feature would be something like: > > Add an internal migration restriction (which may or may not be > exported as a

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-19 Thread Rafael J. Wysocki
On Tuesday 16 of October 2012 15:28:39 Tejun Heo wrote: > Hello, > > This patchset updates cgroup_freezer so that > > * Unfreezable kernel tasks don't prevent a cgroup from transitioning > into FROZEN from FREEZING. There's nothing userland can do with or > about such tasks. > > * Tasks can

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-18 Thread Matt Helsley
On Thu, Oct 18, 2012 at 05:01:53PM -0700, Tejun Heo wrote: > I probably have chosen the wrong word. I mean that it's a hierarchy > management feature implemented at the wrong layer. If we want to > provide cgroup migration locking, it should be implemented at the > cgroup core layer as a contro

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-18 Thread Tejun Heo
Hello, Matt. On Thu, Oct 18, 2012 at 04:47:26PM -0700, Matt Helsley wrote: > > I think the only sane way would be having a userland arbitrator which > > owns the kernel interface to itself and makes policy decisions from > > userland clients and configures cgroup accordingly. > > OK -- yeah, solv

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-18 Thread Matt Helsley
On Thu, Oct 18, 2012 at 03:35:17PM -0700, Tejun Heo wrote: > Hello, Matt. > > On Thu, Oct 18, 2012 at 03:21:55PM -0700, Matt Helsley wrote: > > > Hmmm? Nothing prevents kthreads from being moved around. We only > > > recently added the restriction to prevent migration of the kthreadd > > > (the

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-18 Thread Tejun Heo
Hello, Matt. On Thu, Oct 18, 2012 at 03:21:55PM -0700, Matt Helsley wrote: > > Hmmm? Nothing prevents kthreads from being moved around. We only > > recently added the restriction to prevent migration of the kthreadd > > (the one which creates other kthreads). You can reproduce it with > > khung

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-18 Thread Matt Helsley
On Thu, Oct 18, 2012 at 02:14:34PM -0700, Tejun Heo wrote: > Hello, Matt. > > On Wed, Oct 17, 2012 at 12:16:06PM -0700, Matt Helsley wrote: > > > * Unfreezable kernel tasks don't prevent a cgroup from transitioning > > > into FROZEN from FREEZING. There's nothing userland can do with or > > >

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-18 Thread Tejun Heo
Hello, Matt. On Wed, Oct 17, 2012 at 12:16:06PM -0700, Matt Helsley wrote: > > * Unfreezable kernel tasks don't prevent a cgroup from transitioning > > into FROZEN from FREEZING. There's nothing userland can do with or > > about such tasks. > > Seems like a non-problem. Do you have a testcas

Re: [PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-18 Thread Matt Helsley
On Tue, Oct 16, 2012 at 03:28:39PM -0700, Tejun Heo wrote: > Hello, > > This patchset updates cgroup_freezer so that > > * Unfreezable kernel tasks don't prevent a cgroup from transitioning > into FROZEN from FREEZING. There's nothing userland can do with or > about such tasks. Seems like a

[PATCHSET cgroup/for-3.8] cgroup_freezer: allow migration regardless of freezer state and update locking

2012-10-16 Thread Tejun Heo
Hello, This patchset updates cgroup_freezer so that * Unfreezable kernel tasks don't prevent a cgroup from transitioning into FROZEN from FREEZING. There's nothing userland can do with or about such tasks. * Tasks can be moved in and out of a frozen cgroup. Tasks are made to conform to t