Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Tue, Dec 15, 2015 at 05:29:30PM -0800, Tony Luck wrote: > Copy the existing page fault fixup mechanisms to create a new table > to be used when fixing machine checks. Note: > 1) At this time we only provide a macro to annotate assembly code > 2) We assume all fixups will in code builtin to the

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Tue, Dec 15, 2015 at 05:29:30PM -0800, Tony Luck wrote: > Copy the existing page fault fixup mechanisms to create a new table > to be used when fixing machine checks. Note: > 1) At this time we only provide a macro to annotate assembly code > 2) We assume all fixups will in code builtin to the

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Mon, Dec 21, 2015 at 11:16:44AM -0800, Dan Williams wrote: > I suggested we reverse the dependency and have the driver optionally > "select MCE_KERNEL_RECOVERY". There may be other drivers outside of > LIBNVDIMM that want this functionality enabled. Ah ok, makes sense. -- Regards/Gruss,

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Mon, Dec 21, 2015 at 10:18 AM, Borislav Petkov wrote: > On Tue, Dec 15, 2015 at 05:29:30PM -0800, Tony Luck wrote: >> Copy the existing page fault fixup mechanisms to create a new table >> to be used when fixing machine checks. Note: >> 1) At this time we only provide a macro to annotate

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Tue, Dec 15, 2015 at 05:29:30PM -0800, Tony Luck wrote: > Copy the existing page fault fixup mechanisms to create a new table > to be used when fixing machine checks. Note: > 1) At this time we only provide a macro to annotate assembly code > 2) We assume all fixups will in code builtin to the

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Tue, Dec 15, 2015 at 05:29:30PM -0800, Tony Luck wrote: > Copy the existing page fault fixup mechanisms to create a new table > to be used when fixing machine checks. Note: > 1) At this time we only provide a macro to annotate assembly code > 2) We assume all fixups will in code builtin to the

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Mon, Dec 21, 2015 at 11:16:44AM -0800, Dan Williams wrote: > I suggested we reverse the dependency and have the driver optionally > "select MCE_KERNEL_RECOVERY". There may be other drivers outside of > LIBNVDIMM that want this functionality enabled. Ah ok, makes sense. -- Regards/Gruss,

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Mon, Dec 21, 2015 at 10:18 AM, Borislav Petkov wrote: > On Tue, Dec 15, 2015 at 05:29:30PM -0800, Tony Luck wrote: >> Copy the existing page fault fixup mechanisms to create a new table >> to be used when fixing machine checks. Note: >> 1) At this time we only provide a macro

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Wed, Dec 16, 2015 at 2:51 PM, Luck, Tony wrote: >> Looks generally good. >> >> Reviewed-by: Andy Lutomirski > > You say that to part 1/3 ... what happens when you get to part 3/3 and you > read my attempts at writing x86 assembly code? I'm not at all familiar with that code, and Borislav or

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Wed, Dec 16, 2015 at 2:51 PM, Luck, Tony wrote: >> Looks generally good. >> >> Reviewed-by: Andy Lutomirski > > You say that to part 1/3 ... what happens when you get to part 3/3 and you > read my attempts at writing x86 assembly code? I'm not at all

RE: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

> Looks generally good. > > Reviewed-by: Andy Lutomirski You say that to part 1/3 ... what happens when you get to part 3/3 and you read my attempts at writing x86 assembly code? >> +#ifdef CONFIG_MCE_KERNEL_RECOVERY >> +int fixup_mcexception(struct pt_regs *regs) >> +{ >> + const struct

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Tue, Dec 15, 2015 at 5:29 PM, Tony Luck wrote: > Copy the existing page fault fixup mechanisms to create a new table > to be used when fixing machine checks. Note: > 1) At this time we only provide a macro to annotate assembly code > 2) We assume all fixups will in code builtin to the kernel.

[PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

Copy the existing page fault fixup mechanisms to create a new table to be used when fixing machine checks. Note: 1) At this time we only provide a macro to annotate assembly code 2) We assume all fixups will in code builtin to the kernel. 3) Only for x86_64 4) New code under

Re: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

On Tue, Dec 15, 2015 at 5:29 PM, Tony Luck wrote: > Copy the existing page fault fixup mechanisms to create a new table > to be used when fixing machine checks. Note: > 1) At this time we only provide a macro to annotate assembly code > 2) We assume all fixups will in code

[PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

Copy the existing page fault fixup mechanisms to create a new table to be used when fixing machine checks. Note: 1) At this time we only provide a macro to annotate assembly code 2) We assume all fixups will in code builtin to the kernel. 3) Only for x86_64 4) New code under

RE: [PATCHV3 1/3] x86, ras: Add new infrastructure for machine check fixup tables

> Looks generally good. > > Reviewed-by: Andy Lutomirski You say that to part 1/3 ... what happens when you get to part 3/3 and you read my attempts at writing x86 assembly code? >> +#ifdef CONFIG_MCE_KERNEL_RECOVERY >> +int fixup_mcexception(struct pt_regs *regs) >> +{ >> +