Re: [PATCH_V4] dm9000: Add regulator and reset support to dm9000

2015-01-14 Thread David Miller
From: Zubair Lutfullah Kakakhel Date: Wed, 14 Jan 2015 10:36:17 + > + power = devm_regulator_get(dev, "vcc"); > + if (PTR_ERR(power) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + if (IS_ERR(power)) { > + dev_dbg(dev, "no regulator provided\n"); I know

[PATCH_V4] dm9000: Add regulator and reset support to dm9000

2015-01-14 Thread Zubair Lutfullah Kakakhel
In boards, the dm9000 chip's power and reset can be controlled by gpio. It makes sense to add them to the dm9000 driver and let dt be used to enable power and reset the phy. Signed-off-by: Zubair Lutfullah Kakakhel Signed-off-by: Paul Burton --- V3 Fixed an indentation and removed a call to

Re: [PATCH_V4] dm9000: Add regulator and reset support to dm9000

2015-01-14 Thread David Miller
From: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Date: Wed, 14 Jan 2015 10:36:17 + + power = devm_regulator_get(dev, vcc); + if (PTR_ERR(power) == -EPROBE_DEFER) + return -EPROBE_DEFER; + if (IS_ERR(power)) { + dev_dbg(dev, no regulator

[PATCH_V4] dm9000: Add regulator and reset support to dm9000

2015-01-14 Thread Zubair Lutfullah Kakakhel
In boards, the dm9000 chip's power and reset can be controlled by gpio. It makes sense to add them to the dm9000 driver and let dt be used to enable power and reset the phy. Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Signed-off-by: Paul Burton paul.bur...@imgtec.com ---