Re: [PATCHv1] ASoC: cpcap: fix microphone timeslot mask

2021-02-01 Thread Mark Brown
On Sat, 23 Jan 2021 18:29:45 +0100, Sebastian Reichel wrote: > The correct mask is 0x1f8 (Bit 3-8), but due to missing BIT() 0xf (Bit > 0-3) was set instead. This means setting of CPCAP_BIT_MIC1_RX_TIMESLOT0 > (Bit 3) still worked (part of both masks). On the other hand the code > does not

Re: [PATCHv1] ASoC: cpcap: fix microphone timeslot mask

2021-01-30 Thread Tony Lindgren
* Sebastian Reichel [210123 17:30]: > This is compile tested only, since I currently do not have > my Droid 4 ready for running some tests. Maybe Tony, Pavel or > Merlijn can give it a go using e.g. arecord. I just tried recording with arecord -D plughw:CARD=Audio,DEV=1 | hd but only see the

[PATCHv1] ASoC: cpcap: fix microphone timeslot mask

2021-01-23 Thread Sebastian Reichel
The correct mask is 0x1f8 (Bit 3-8), but due to missing BIT() 0xf (Bit 0-3) was set instead. This means setting of CPCAP_BIT_MIC1_RX_TIMESLOT0 (Bit 3) still worked (part of both masks). On the other hand the code does not properly clear the other MIC timeslot bits. I think this is not a problem,