Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-04 Thread Sebastian Reichel
Hi, On Tue, Mar 04, 2014 at 10:20:32PM +0100, Belisko Marek wrote: > On Sat, Mar 1, 2014 at 12:22 AM, Sebastian Reichel wrote: > > On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote: > >> Seems I found issue. I have missing property ti,system-uses-second-madc-irq > >> as original

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-04 Thread Belisko Marek
Hi Sebastian, On Sat, Mar 1, 2014 at 12:22 AM, Sebastian Reichel wrote: > Hi Marek, > > On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote: >> Seems I found issue. I have missing property ti,system-uses-second-madc-irq >> as original twl4030_madc_battery used SW2 but this change

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-04 Thread Belisko Marek
Hi Sebastian, On Sat, Mar 1, 2014 at 12:22 AM, Sebastian Reichel s...@debian.org wrote: Hi Marek, On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote: Seems I found issue. I have missing property ti,system-uses-second-madc-irq as original twl4030_madc_battery used SW2 but this

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-04 Thread Sebastian Reichel
Hi, On Tue, Mar 04, 2014 at 10:20:32PM +0100, Belisko Marek wrote: On Sat, Mar 1, 2014 at 12:22 AM, Sebastian Reichel s...@debian.org wrote: On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote: Seems I found issue. I have missing property ti,system-uses-second-madc-irq as

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-01 Thread Jonathan Cameron
On 01/03/14 11:17, Jonathan Cameron wrote: On 26/02/14 00:46, Sebastian Reichel wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel The error handling needs tidying up. Otherwise this looks fine to me. Note that you

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-01 Thread Jonathan Cameron
On 26/02/14 00:46, Sebastian Reichel wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel The error handling needs tidying up. Otherwise this looks fine to me. Note that you (really me) may get some grief over the DT

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-01 Thread Jonathan Cameron
On 26/02/14 00:46, Sebastian Reichel wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel s...@debian.org The error handling needs tidying up. Otherwise this looks fine to me. Note that you (really me) may get some grief

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-01 Thread Jonathan Cameron
On 01/03/14 11:17, Jonathan Cameron wrote: On 26/02/14 00:46, Sebastian Reichel wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel s...@debian.org The error handling needs tidying up. Otherwise this looks fine to me.

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Sebastian Reichel
Hi Marek, On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote: > Seems I found issue. I have missing property ti,system-uses-second-madc-irq > as original twl4030_madc_battery used SW2 but this change doesn't fix > completely > the problem. I remember adding this property because you

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
On Fri, Feb 28, 2014 at 10:13 PM, Belisko Marek wrote: > On Fri, Feb 28, 2014 at 10:08 PM, Sebastian Reichel wrote: >> On Fri, Feb 28, 2014 at 09:32:12PM +0100, Belisko Marek wrote: >>> On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel wrote: >>> > On Thu, Feb 27, 2014 at 10:34:35PM +0100,

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
On Fri, Feb 28, 2014 at 10:08 PM, Sebastian Reichel wrote: > On Fri, Feb 28, 2014 at 09:32:12PM +0100, Belisko Marek wrote: >> On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel wrote: >> > On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: >> >> Well I've tried and it's worse :). I

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Sebastian Reichel
On Fri, Feb 28, 2014 at 09:32:12PM +0100, Belisko Marek wrote: > On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel wrote: > > On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: > >> Well I've tried and it's worse :). I got during booting: > >> [2.218383] ERROR: could not get IIO

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
On Fri, Feb 28, 2014 at 9:32 PM, Belisko Marek wrote: > Hi Sebastian, > > On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel wrote: >> On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: >>> Well I've tried and it's worse :). I got during booting: >>> [2.218383] ERROR: could not

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
Hi Sebastian, On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel wrote: > On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: >> Well I've tried and it's worse :). I got during booting: >> [2.218383] ERROR: could not get IIO channel /battery:temp(0) >> [2.224639] platform

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
Hi Sebastian, On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel s...@debian.org wrote: On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: Well I've tried and it's worse :). I got during booting: [2.218383] ERROR: could not get IIO channel /battery:temp(0) [2.224639]

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
On Fri, Feb 28, 2014 at 9:32 PM, Belisko Marek marek.beli...@gmail.com wrote: Hi Sebastian, On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel s...@debian.org wrote: On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: Well I've tried and it's worse :). I got during booting: [

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Sebastian Reichel
On Fri, Feb 28, 2014 at 09:32:12PM +0100, Belisko Marek wrote: On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel s...@debian.org wrote: On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: Well I've tried and it's worse :). I got during booting: [2.218383] ERROR: could not

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
On Fri, Feb 28, 2014 at 10:08 PM, Sebastian Reichel s...@debian.org wrote: On Fri, Feb 28, 2014 at 09:32:12PM +0100, Belisko Marek wrote: On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel s...@debian.org wrote: On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: Well I've tried

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
On Fri, Feb 28, 2014 at 10:13 PM, Belisko Marek marek.beli...@gmail.com wrote: On Fri, Feb 28, 2014 at 10:08 PM, Sebastian Reichel s...@debian.org wrote: On Fri, Feb 28, 2014 at 09:32:12PM +0100, Belisko Marek wrote: On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel s...@debian.org wrote: On

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Sebastian Reichel
Hi Marek, On Fri, Feb 28, 2014 at 11:32:22PM +0100, Belisko Marek wrote: Seems I found issue. I have missing property ti,system-uses-second-madc-irq as original twl4030_madc_battery used SW2 but this change doesn't fix completely the problem. I remember adding this property because you

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-27 Thread Sebastian Reichel
On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: > Well I've tried and it's worse :). I got during booting: > [2.218383] ERROR: could not get IIO channel /battery:temp(0) > [2.224639] platform battery.4: Driver twl4030_madc_battery > requests probe deferral > Not sure if it's

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-27 Thread Belisko Marek
Hi Sebastian, On Wed, Feb 26, 2014 at 10:54 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote: >> [...] >> > + int val, err; >> > + err = iio_read_channel_average_raw(channel, ); >> Where this function comes from? I cannot find it in

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-27 Thread Belisko Marek
Hi Sebastian, On Wed, Feb 26, 2014 at 10:54 PM, Sebastian Reichel s...@debian.org wrote: Hi, On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote: [...] + int val, err; + err = iio_read_channel_average_raw(channel, val); Where this function comes from? I cannot find

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-27 Thread Sebastian Reichel
On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: Well I've tried and it's worse :). I got during booting: [2.218383] ERROR: could not get IIO channel /battery:temp(0) [2.224639] platform battery.4: Driver twl4030_madc_battery requests probe deferral Not sure if it's just

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-26 Thread Sebastian Reichel
Hi, On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote: > [...] > > + int val, err; > > + err = iio_read_channel_average_raw(channel, ); > Where this function comes from? I cannot find it in current linux-next > (only iio_read_channel_raw()). Am I missing some patches? Thx.

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-26 Thread Belisko Marek
Hi Sebastian, On Wed, Feb 26, 2014 at 1:46 AM, Sebastian Reichel wrote: > Update rx51-battery driver to use the new IIO API of > twl4030-madc and add DT support. > > Signed-off-by: Sebastian Reichel > --- > drivers/power/rx51_battery.c | 68 > +--- > 1

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-26 Thread Belisko Marek
Hi Sebastian, On Wed, Feb 26, 2014 at 1:46 AM, Sebastian Reichel s...@debian.org wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel s...@debian.org --- drivers/power/rx51_battery.c | 68

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-26 Thread Sebastian Reichel
Hi, On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote: [...] + int val, err; + err = iio_read_channel_average_raw(channel, val); Where this function comes from? I cannot find it in current linux-next (only iio_read_channel_raw()). Am I missing some patches? Thx. Ah

[PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-25 Thread Sebastian Reichel
Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel --- drivers/power/rx51_battery.c | 68 +--- 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/drivers/power/rx51_battery.c

[PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-25 Thread Sebastian Reichel
Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel s...@debian.org --- drivers/power/rx51_battery.c | 68 +--- 1 file changed, 45 insertions(+), 23 deletions(-) diff --git