Re: [PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read()

2013-03-21 Thread Dave Hansen
On 03/15/2013 06:22 AM, Kirill A. Shutemov wrote: > Hillf Danton wrote: >> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov >> wrote: >>> >>> There's only one caller of do_generic_file_read() and the only actor is >>> file_read_actor(). No reason to have a callback parameter. >>> >> This cleanu

Re: [PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read()

2013-03-15 Thread Kirill A. Shutemov
Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > > > There's only one caller of do_generic_file_read() and the only actor is > > file_read_actor(). No reason to have a callback parameter. > > > This cleanup is not urgent if it nukes no barrier for THP cache.

Re: [PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read()

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov wrote: > > There's only one caller of do_generic_file_read() and the only actor is > file_read_actor(). No reason to have a callback parameter. > This cleanup is not urgent if it nukes no barrier for THP cache. Hillf -- To unsubscribe from this

Re: [PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read()

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > There's only one caller of do_generic_file_read() and the only actor is > file_read_actor(). No reason to have a callback parameter. > This cleanup is not urgent if it nukes no barrier for THP cache. Hill

[PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read()

2013-03-14 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" There's only one caller of do_generic_file_read() and the only actor is file_read_actor(). No reason to have a callback parameter. Signed-off-by: Kirill A. Shutemov --- mm/filemap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/f