Re: [PATCHv2][SMB3] Add kernel trace support

On Sat, May 19, 2018 at 08:56:39PM -0500, Steve French wrote: > On Sat, May 19, 2018 at 6:22 PM, Dave Chinner wrote: > > On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: > >> On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > >> > On Thu, May

Re: [PATCHv2][SMB3] Add kernel trace support

On Sat, May 19, 2018 at 08:56:39PM -0500, Steve French wrote: > On Sat, May 19, 2018 at 6:22 PM, Dave Chinner wrote: > > On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: > >> On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > >> > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve

Re: [PATCHv2][SMB3] Add kernel trace support

On Sat, May 19, 2018 at 6:22 PM, Dave Chinner wrote: > On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: >> On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: >> > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical >> >

Re: [PATCHv2][SMB3] Add kernel trace support

On Sat, May 19, 2018 at 6:22 PM, Dave Chinner wrote: > On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: >> On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: >> > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical >> > wrote: >> >> Patch updated with

Re: [PATCHv2][SMB3] Add kernel trace support

On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: > On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical > > wrote: > >> Patch updated with additional tracepoint locations and some

Re: [PATCHv2][SMB3] Add kernel trace support

On Fri, May 18, 2018 at 01:43:14PM -0700, Steve French wrote: > On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical > > wrote: > >> Patch updated with additional tracepoint locations and some formatting > >>

Re: [PATCHv2][SMB3] Add kernel trace support

On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical > wrote: >> Patch updated with additional tracepoint locations and some formatting >> improvements. There are some obvious additional tracepoints that

Re: [PATCHv2][SMB3] Add kernel trace support

On Fri, May 18, 2018 at 11:46 AM, Ralph Böhme wrote: > On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical > wrote: >> Patch updated with additional tracepoint locations and some formatting >> improvements. There are some obvious additional tracepoints that could >> be

Re: [PATCHv2][SMB3] Add kernel trace support

On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical wrote: > Patch updated with additional tracepoint locations and some formatting > improvements. There are some obvious additional tracepoints that could > be added, but this should be a reasonable group to start with. > >

Re: [PATCHv2][SMB3] Add kernel trace support

On Thu, May 17, 2018 at 09:36:36PM -0500, Steve French via samba-technical wrote: > Patch updated with additional tracepoint locations and some formatting > improvements. There are some obvious additional tracepoints that could > be added, but this should be a reasonable group to start with. > >

Re: [PATCHv2][SMB3] Add kernel trace support

On Fri, May 18, 2018 at 1:00 AM, ronnie sahlberg wrote: > Fair enough. > > Onto a second point then, for future patches. > > There are a lot of places where we do not (yet) pass a tcon as argument. > Can we make a policy decision to mandate that every tracepoint MUST >

Re: [PATCHv2][SMB3] Add kernel trace support

On Fri, May 18, 2018 at 1:00 AM, ronnie sahlberg wrote: > Fair enough. > > Onto a second point then, for future patches. > > There are a lot of places where we do not (yet) pass a tcon as argument. > Can we make a policy decision to mandate that every tracepoint MUST > log tid, sid? > > And thus,

Re: [PATCHv2][SMB3] Add kernel trace support

Fair enough. Onto a second point then, for future patches. There are a lot of places where we do not (yet) pass a tcon as argument. Can we make a policy decision to mandate that every tracepoint MUST log tid, sid? And thus, if you need a new tracepoint in a function where tcon is not available

Re: [PATCHv2][SMB3] Add kernel trace support

Fair enough. Onto a second point then, for future patches. There are a lot of places where we do not (yet) pass a tcon as argument. Can we make a policy decision to mandate that every tracepoint MUST log tid, sid? And thus, if you need a new tracepoint in a function where tcon is not available

Re: [PATCHv2][SMB3] Add kernel trace support

On Thu, May 17, 2018 at 10:28 PM, Ronnie Sahlberg wrote: > Very nice. > > Acked-by: Ronnie Sahlberg > > Possibly change the output from > pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0 > to > cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0 > > just to make it easier for

Re: [PATCHv2][SMB3] Add kernel trace support

On Thu, May 17, 2018 at 10:28 PM, Ronnie Sahlberg wrote: > Very nice. > > Acked-by: Ronnie Sahlberg > > Possibly change the output from > pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0 > to > cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0 > > just to make it easier for human-searching. I think the cmd will be

Re: [PATCHv2][SMB3] Add kernel trace support

;samba-technical" <samba-techni...@lists.samba.org>, "linux-fsdevel" <linux-fsde...@vger.kernel.org> Sent: Friday, 18 May, 2018 12:36:36 PM Subject: [PATCHv2][SMB3] Add kernel trace support Patch updated with additional tracepoint locations and some formatting improvemen

Re: [PATCHv2][SMB3] Add kernel trace support

for as all cmd= entries will be aligned to the same column. - Original Message - From: "Steve French" To: "CIFS" , "LKML" , "samba-technical" , "linux-fsdevel" Sent: Friday, 18 May, 2018 12:36:36 PM Subject: [PATCHv2][SMB3] Add k

[PATCHv2][SMB3] Add kernel trace support

Patch updated with additional tracepoint locations and some formatting improvements. There are some obvious additional tracepoints that could be added, but this should be a reasonable group to start with. >From edc02d6f9dc24963d510c7ef59067428d3b082d3 Mon Sep 17 00:00:00 2001 From: Steve French

[PATCHv2][SMB3] Add kernel trace support

Patch updated with additional tracepoint locations and some formatting improvements. There are some obvious additional tracepoints that could be added, but this should be a reasonable group to start with. >From edc02d6f9dc24963d510c7ef59067428d3b082d3 Mon Sep 17 00:00:00 2001 From: Steve French