From: Linus Lüssing
Date: Thu, 25 Jul 2013 15:56:20 +0200
> + atomic64_t multicast_querier_delay_time;
Please don't use an atomic64_t here, it's pointless.
You're only doing set and read operations on it, there's absolutely
nothing atomic about that.
You have to make
From: Linus Lüssing linus.luess...@web.de
Date: Thu, 25 Jul 2013 15:56:20 +0200
+ atomic64_t multicast_querier_delay_time;
Please don't use an atomic64_t here, it's pointless.
You're only doing set and read operations on it, there's absolutely
nothing atomic about
On Fri, Jul 26, 2013 at 11:19:00PM +0100, Adam Baker wrote:
> On 25/07/13 14:56, Linus Lüssing wrote:
> >If there is no querier on a link then we won't get periodic reports and
> >therefore won't be able to learn about multicast listeners behind ports,
> >potentially leading to lost multicast
On Fri, Jul 26, 2013 at 11:19:00PM +0100, Adam Baker wrote:
On 25/07/13 14:56, Linus Lüssing wrote:
If there is no querier on a link then we won't get periodic reports and
therefore won't be able to learn about multicast listeners behind ports,
potentially leading to lost multicast packets,
On 25/07/13 14:56, Linus Lüssing wrote:
If there is no querier on a link then we won't get periodic reports and
therefore won't be able to learn about multicast listeners behind ports,
potentially leading to lost multicast packets, especially for multicast
listeners that joined before the
On 25/07/13 14:56, Linus Lüssing wrote:
If there is no querier on a link then we won't get periodic reports and
therefore won't be able to learn about multicast listeners behind ports,
potentially leading to lost multicast packets, especially for multicast
listeners that joined before the
On Thu, Jul 25, 2013 at 09:01:40AM -0700, Stephen Hemminger wrote:
> On Thu, 25 Jul 2013 15:56:20 +0200
> Linus Lüssing wrote:
>
> >
> > +static void br_multicast_update_querier_timer(struct net_bridge *br,
> > + unsigned long max_delay)
> > +{
> > +
On Thu, 25 Jul 2013 15:56:20 +0200
Linus Lüssing wrote:
>
> +static void br_multicast_update_querier_timer(struct net_bridge *br,
> + unsigned long max_delay)
> +{
> + if (!timer_pending(>multicast_querier_timer))
> +
If there is no querier on a link then we won't get periodic reports and
therefore won't be able to learn about multicast listeners behind ports,
potentially leading to lost multicast packets, especially for multicast
listeners that joined before the creation of the bridge.
These lost multicast
If there is no querier on a link then we won't get periodic reports and
therefore won't be able to learn about multicast listeners behind ports,
potentially leading to lost multicast packets, especially for multicast
listeners that joined before the creation of the bridge.
These lost multicast
On Thu, 25 Jul 2013 15:56:20 +0200
Linus Lüssing linus.luess...@web.de wrote:
+static void br_multicast_update_querier_timer(struct net_bridge *br,
+ unsigned long max_delay)
+{
+ if (!timer_pending(br-multicast_querier_timer))
+
On Thu, Jul 25, 2013 at 09:01:40AM -0700, Stephen Hemminger wrote:
On Thu, 25 Jul 2013 15:56:20 +0200
Linus Lüssing linus.luess...@web.de wrote:
+static void br_multicast_update_querier_timer(struct net_bridge *br,
+ unsigned long max_delay)
+{
12 matches
Mail list logo
