Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Maxim, On Fri, Jan 26, 2018 at 12:24:54PM +0300, Maxim Uvarov wrote: > Bin, > > I looked to my local git and code does not have this latest line "goto > finish". It was tested without it and everything worked. Right now I > can not get access to that hardware to check with and without. But >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Maxim, On Fri, Jan 26, 2018 at 12:24:54PM +0300, Maxim Uvarov wrote: > Bin, > > I looked to my local git and code does not have this latest line "goto > finish". It was tested without it and everything worked. Right now I > can not get access to that hardware to check with and without. But >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi Maxim, unfortunately we cannot test the latest kernel right now, because we have custom drivers and additional changes that need to be ported, but the MUSB driver in our kernel should contain all fixes from

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi Maxim, unfortunately we cannot test the latest kernel right now, because we have custom drivers and additional changes that need to be ported, but the MUSB driver in our kernel should contain all fixes from

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Bin, I looked to my local git and code does not have this latest line "goto finish". It was tested without it and everything worked. Right now I can not get access to that hardware to check with and without. But only can confirm that without "goto finish" function works with bunch of drivers

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Bin, I looked to my local git and code does not have this latest line "goto finish". It was tested without it and everything worked. Right now I can not get access to that hardware to check with and without. But only can confirm that without "goto finish" function works with bunch of drivers

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Maxim, On Thu, Jan 25, 2018 at 07:24:02PM +0300, Maxim Uvarov wrote: > [1] says that issue is with back ported driver to 3.12.10. Can the > latest kernel be tested on the same hw? Agreed that it should be tested with the latest kernel. But my concern now is if stopping scheduling urbs on errors

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Maxim, On Thu, Jan 25, 2018 at 07:24:02PM +0300, Maxim Uvarov wrote: > [1] says that issue is with back ported driver to 3.12.10. Can the > latest kernel be tested on the same hw? Agreed that it should be tested with the latest kernel. But my concern now is if stopping scheduling urbs on errors

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

[1] says that issue is with back ported driver to 3.12.10. Can the latest kernel be tested on the same hw? Maxim. 2018-01-25 18:45 GMT+03:00 Bin Liu : > Hi Yegor and Max, > > On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: >> On Tue, May 3, 2016 at 3:48 PM, Bin Liu

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

[1] says that issue is with back ported driver to 3.12.10. Can the latest kernel be tested on the same hw? Maxim. 2018-01-25 18:45 GMT+03:00 Bin Liu : > Hi Yegor and Max, > > On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: >> On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: >> >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi Yegor and Max, On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: > On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > > Hi, > > > > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: > >> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi Yegor and Max, On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: > On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > > Hi, > > > > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: > >> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: > >> > Hi, > >> > > >> > On

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Thu, May 05, 2016 at 04:39:06PM +0300, Sergei Shtylyov wrote: > On 5/5/2016 4:31 PM, Bin Liu wrote: > > yes, it also works with that reset and go to finish: > > diff --git a/drivers/usb/musb/musb_host.c > b/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Thu, May 05, 2016 at 04:39:06PM +0300, Sergei Shtylyov wrote: > On 5/5/2016 4:31 PM, Bin Liu wrote: > > yes, it also works with that reset and go to finish: > > diff --git a/drivers/usb/musb/musb_host.c > b/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On 5/5/2016 4:31 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10 @@ void

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On 5/5/2016 4:31 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10 @@ void

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Thu, May 05, 2016 at 04:21:23PM +0300, Sergei Shtylyov wrote: > Hello. > > On 5/4/2016 10:17 PM, Bin Liu wrote: > > >>yes, it also works with that reset and go to finish: > >> > >>diff --git a/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Thu, May 05, 2016 at 04:21:23PM +0300, Sergei Shtylyov wrote: > Hello. > > On 5/4/2016 10:17 PM, Bin Liu wrote: > > >>yes, it also works with that reset and go to finish: > >> > >>diff --git a/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hello. On 5/4/2016 10:17 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10 @@

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hello. On 5/4/2016 10:17 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10 @@

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, May 04, 2016 at 01:19:27PM -0700, Greg KH wrote: > On Wed, May 04, 2016 at 02:17:15PM -0500, Bin Liu wrote: > > Hi, > > > > On Wed, May 04, 2016 at 10:02:16PM +0300, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 05/04/2016 09:56 PM, Bin Liu wrote: > > > > > > yes, it

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, May 04, 2016 at 01:19:27PM -0700, Greg KH wrote: > On Wed, May 04, 2016 at 02:17:15PM -0500, Bin Liu wrote: > > Hi, > > > > On Wed, May 04, 2016 at 10:02:16PM +0300, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 05/04/2016 09:56 PM, Bin Liu wrote: > > > > > > yes, it

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Wed, May 04, 2016 at 02:17:15PM -0500, Bin Liu wrote: > Hi, > > On Wed, May 04, 2016 at 10:02:16PM +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 05/04/2016 09:56 PM, Bin Liu wrote: > > > > yes, it also works with that reset and go to finish: > > > > diff --git

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Wed, May 04, 2016 at 02:17:15PM -0500, Bin Liu wrote: > Hi, > > On Wed, May 04, 2016 at 10:02:16PM +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 05/04/2016 09:56 PM, Bin Liu wrote: > > > > yes, it also works with that reset and go to finish: > > > > diff --git

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, May 04, 2016 at 10:02:16PM +0300, Sergei Shtylyov wrote: > Hello. > > On 05/04/2016 09:56 PM, Bin Liu wrote: > > yes, it also works with that reset and go to finish: > > diff --git a/drivers/usb/musb/musb_host.c > b/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, May 04, 2016 at 10:02:16PM +0300, Sergei Shtylyov wrote: > Hello. > > On 05/04/2016 09:56 PM, Bin Liu wrote: > > yes, it also works with that reset and go to finish: > > diff --git a/drivers/usb/musb/musb_host.c > b/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hello. On 05/04/2016 09:56 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hello. On 05/04/2016 09:56 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, May 04, 2016 at 04:49:50PM +0200, Yegor Yefremov wrote: > On Tue, May 3, 2016 at 4:35 PM, Bin Liu wrote: > > Hi, > > > > On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: > >> On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > >> > Hi, > >> >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, May 04, 2016 at 04:49:50PM +0200, Yegor Yefremov wrote: > On Tue, May 3, 2016 at 4:35 PM, Bin Liu wrote: > > Hi, > > > > On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: > >> On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > >> > Hi, > >> > > >> > On Tue, May 03, 2016

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Tue, May 3, 2016 at 4:35 PM, Bin Liu wrote: > Hi, > > On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: >> On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: >> > Hi, >> > >> > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: >> >> On Thu,

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Tue, May 3, 2016 at 4:35 PM, Bin Liu wrote: > Hi, > > On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: >> On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: >> > Hi, >> > >> > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: >> >> On Thu, Apr 28, 2016 at 4:37 PM, Bin

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: > On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > > Hi, > > > > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: > >> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: > >> > Hi, > >> >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: > On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > > Hi, > > > > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: > >> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: > >> > Hi, > >> > > >> > On Thu, Apr 28, 2016

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > Hi, > > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: >> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: >> > Hi, >> > >> > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: >> > >> >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > Hi, > > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: >> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: >> > Hi, >> > >> > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: >> > >> > [snip] >> > >> >> Hello Bin, >>

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: > On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: > > Hi, > > > > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: > > > > [snip] > > > >> Hello Bin, > >> > >> yes, it also works with that reset and go

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: > On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: > > Hi, > > > > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: > > > > [snip] > > > >> Hello Bin, > >> > >> yes, it also works with that reset and go to finish: >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: > Hi, > > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: > > [snip] > >> Hello Bin, >> >> yes, it also works with that reset and go to finish: >> >> diff --git a/drivers/usb/musb/musb_host.c

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: > Hi, > > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: > > [snip] > >> Hello Bin, >> >> yes, it also works with that reset and go to finish: >> >> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c >> index

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: [snip] > Hello Bin, > > yes, it also works with that reset and go to finish: > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c > index c3d5fc9..8cd98e7 100644 > --- a/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote: [snip] > Hello Bin, > > yes, it also works with that reset and go to finish: > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c > index c3d5fc9..8cd98e7 100644 > --- a/drivers/usb/musb/musb_host.c >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-28 0:28 GMT+03:00 Bin Liu : > Hi, > > On Wed, Apr 27, 2016 at 02:13:56PM -0500, Bin Liu wrote: >> Hi, >> >> On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: >> > 2016-04-27 18:46 GMT+03:00 Bin Liu : >> > > Hi, >> > > >> > > On Wed, Apr 27, 2016 at

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-28 0:28 GMT+03:00 Bin Liu : > Hi, > > On Wed, Apr 27, 2016 at 02:13:56PM -0500, Bin Liu wrote: >> Hi, >> >> On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: >> > 2016-04-27 18:46 GMT+03:00 Bin Liu : >> > > Hi, >> > > >> > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, Apr 27, 2016 at 02:13:56PM -0500, Bin Liu wrote: > Hi, > > On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: > > 2016-04-27 18:46 GMT+03:00 Bin Liu : > > > Hi, > > > > > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > > >> Fix soft lockup

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, Apr 27, 2016 at 02:13:56PM -0500, Bin Liu wrote: > Hi, > > On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: > > 2016-04-27 18:46 GMT+03:00 Bin Liu : > > > Hi, > > > > > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > > >> Fix soft lockup when resetting

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: > 2016-04-27 18:46 GMT+03:00 Bin Liu : > > Hi, > > > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > >> Fix soft lockup when resetting remote device attached > >> to usb host. Configuration: > >> pppd

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: > 2016-04-27 18:46 GMT+03:00 Bin Liu : > > Hi, > > > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > >> Fix soft lockup when resetting remote device attached > >> to usb host. Configuration: > >> pppd -> musb hub ->

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-27 18:46 GMT+03:00 Bin Liu : > Hi, > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: >> Fix soft lockup when resetting remote device attached >> to usb host. Configuration: >> pppd -> musb hub -> usb-serial -> gsm modem > > I have heard a few reports similar to

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-27 18:46 GMT+03:00 Bin Liu : > Hi, > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: >> Fix soft lockup when resetting remote device attached >> to usb host. Configuration: >> pppd -> musb hub -> usb-serial -> gsm modem > > I have heard a few reports similar to this symptom,

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > Fix soft lockup when resetting remote device attached > to usb host. Configuration: > pppd -> musb hub -> usb-serial -> gsm modem I have heard a few reports similar to this symptom, but never been able to reproduce it on my side.

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

Hi, On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > Fix soft lockup when resetting remote device attached > to usb host. Configuration: > pppd -> musb hub -> usb-serial -> gsm modem I have heard a few reports similar to this symptom, but never been able to reproduce it on my side.

[PATCHv2] musb_host: fix lockup on rxcsr_h_error

Fix soft lockup when resetting remote device attached to usb host. Configuration: pppd -> musb hub -> usb-serial -> gsm modem When gsm modem resets, musb rolls in incoming rx interrupts which does not give any time to other application as result it totally lock ups. Solution is to keep original

[PATCHv2] musb_host: fix lockup on rxcsr_h_error

Fix soft lockup when resetting remote device attached to usb host. Configuration: pppd -> musb hub -> usb-serial -> gsm modem When gsm modem resets, musb rolls in incoming rx interrupts which does not give any time to other application as result it totally lock ups. Solution is to keep original