Re: [PATCHv2] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

2014-05-26 Thread Paul Clements
On Sun, May 25, 2014 at 6:22 PM, Hani Benhabiles wrote: > Len field is already set to zero, but not the from field which is sent as > 0xfe00. This makes no sense, and may cause confuse server > implementations doing sanity checks (qemu-nbd is an example.) > > Signed-off-by: Hani

Re: [PATCHv2] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

2014-05-26 Thread Paul Clements
On Sun, May 25, 2014 at 6:22 PM, Hani Benhabiles kroo...@gmail.com wrote: Len field is already set to zero, but not the from field which is sent as 0xfe00. This makes no sense, and may cause confuse server implementations doing sanity checks (qemu-nbd is an example.)

[PATCHv2] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

2014-05-25 Thread Hani Benhabiles
Len field is already set to zero, but not the from field which is sent as 0xfe00. This makes no sense, and may cause confuse server implementations doing sanity checks (qemu-nbd is an example.) Signed-off-by: Hani Benhabiles --- Compared to v1: * Zero the request structure instead

[PATCHv2] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

2014-05-25 Thread Hani Benhabiles
Len field is already set to zero, but not the from field which is sent as 0xfe00. This makes no sense, and may cause confuse server implementations doing sanity checks (qemu-nbd is an example.) Signed-off-by: Hani Benhabiles h...@linux.com --- Compared to v1: * Zero the request