Re: [PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data

2016-09-05 Thread Thierry Reding
On Thu, Aug 25, 2016 at 06:47:09PM +0200, Olliver Schinagl wrote: > The lpc18xx driver currently manipulates the pwm_device struct directly > rather then using the pwm_set_chip_data. While the current method may > save a clock cycle or two, it is more obvious that data is set to > the local chip

Re: [PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data

2016-09-05 Thread Thierry Reding
On Thu, Aug 25, 2016 at 06:47:09PM +0200, Olliver Schinagl wrote: > The lpc18xx driver currently manipulates the pwm_device struct directly > rather then using the pwm_set_chip_data. While the current method may > save a clock cycle or two, it is more obvious that data is set to > the local chip

Re: [PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data

2016-09-02 Thread Ariel D'Alessandro
Hi Olliver, On 08/25/2016 01:47 PM, Olliver Schinagl wrote: > The lpc18xx driver currently manipulates the pwm_device struct directly > rather then using the pwm_set_chip_data. While the current method may > save a clock cycle or two, it is more obvious that data is set to > the local chip data

Re: [PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data

2016-09-02 Thread Ariel D'Alessandro
Hi Olliver, On 08/25/2016 01:47 PM, Olliver Schinagl wrote: > The lpc18xx driver currently manipulates the pwm_device struct directly > rather then using the pwm_set_chip_data. While the current method may > save a clock cycle or two, it is more obvious that data is set to > the local chip data

[PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data

2016-08-25 Thread Olliver Schinagl
The lpc18xx driver currently manipulates the pwm_device struct directly rather then using the pwm_set_chip_data. While the current method may save a clock cycle or two, it is more obvious that data is set to the local chip data pointer. Signed-off-by: Olliver Schinagl --- Hi,

[PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data

2016-08-25 Thread Olliver Schinagl
The lpc18xx driver currently manipulates the pwm_device struct directly rather then using the pwm_set_chip_data. While the current method may save a clock cycle or two, it is more obvious that data is set to the local chip data pointer. Signed-off-by: Olliver Schinagl --- Hi, This is a resend