Re: [PATCHv2] serial: 8250: change lock order in serial8250_do_startup()

2020-08-19 Thread Andy Shevchenko
On Wed, Aug 19, 2020 at 06:27:26PM +0900, Sergey Senozhatsky wrote: > On (20/08/19 11:21), Petr Mladek wrote: > > > > The patch is committed in printk/linux.git, branch for-5.10. > > Petr, as far as I can tell, Greg has applied it to gregkh/tty.git It's fine to have it in two or more repos, duri

Re: [PATCHv2] serial: 8250: change lock order in serial8250_do_startup()

2020-08-19 Thread Sergey Senozhatsky
On (20/08/19 11:21), Petr Mladek wrote: > > The patch is committed in printk/linux.git, branch for-5.10. Petr, as far as I can tell, Greg has applied it to gregkh/tty.git -ss

Re: [PATCHv2] serial: 8250: change lock order in serial8250_do_startup()

2020-08-19 Thread Petr Mladek
On Mon 2020-08-17 11:26:46, Sergey Senozhatsky wrote: > We have a number of "uart.port->desc.lock vs desc.lock->uart.port" > lockdep reports coming from 8250 driver; this causes a bit of trouble > to people, so let's fix it. > > The problem is reverse lock order in two different call paths: > > c

[PATCHv2] serial: 8250: change lock order in serial8250_do_startup()

2020-08-16 Thread Sergey Senozhatsky
We have a number of "uart.port->desc.lock vs desc.lock->uart.port" lockdep reports coming from 8250 driver; this causes a bit of trouble to people, so let's fix it. The problem is reverse lock order in two different call paths: chain #1: serial8250_do_startup() spin_lock_irqsave(&port->lock);