Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-21 Thread kbuild test robot
Hi Nikolaus, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v5.0-rc4 next-20190220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-21 Thread Greg Kroah-Hartman
On Thu, Feb 21, 2019 at 09:37:33AM +0100, Nikolaus Voss wrote: > Hi Greg, > > On Wed, 20 Feb 2019, Greg Kroah-Hartman wrote: > > On Wed, Feb 20, 2019 at 04:22:00PM +0100, Nikolaus Voss wrote: > > > > > v2: fix tps6598x_exec_cmd also > > > > > --- > > > > > drivers/usb/typec/tps6598x.c | 26

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-21 Thread Nikolaus Voss
Hi Greg, On Wed, 20 Feb 2019, Greg Kroah-Hartman wrote: On Wed, Feb 20, 2019 at 04:22:00PM +0100, Nikolaus Voss wrote: v2: fix tps6598x_exec_cmd also --- drivers/usb/typec/tps6598x.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 04:22:00PM +0100, Nikolaus Voss wrote: > > > v2: fix tps6598x_exec_cmd also > > > --- > > > drivers/usb/typec/tps6598x.c | 26 -- > > > 1 file changed, 20 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/usb/typec/tps6598x.c

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Greg Kroah-Hartman wrote: On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes)

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Guenter Roeck wrote: On 2/20/19 4:57 AM, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes.

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 04:14:23PM +0200, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: On Wed, 20 Feb 2019, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: Commit

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > adapters, but the problem described with regmap-i2c not handling > SMBus block transfers (i.e. read and writes) correctly also exists > with writes. > > As

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Guenter Roeck
On 2/20/19 4:57 AM, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes. As workaround, this patch adds a block

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Heikki Krogerus
On Wed, Feb 20, 2019 at 04:14:23PM +0200, Heikki Krogerus wrote: > On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: > > On Wed, 20 Feb 2019, Heikki Krogerus wrote: > > > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > > > > Commit 1a2f474d328f handles block _reads_

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Heikki Krogerus
On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: > On Wed, 20 Feb 2019, Heikki Krogerus wrote: > > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > > > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > > > adapters, but the problem described with

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
On Wed, 20 Feb 2019, Heikki Krogerus wrote: On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly

Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Heikki Krogerus
On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > adapters, but the problem described with regmap-i2c not handling > SMBus block transfers (i.e. read and writes) correctly also exists > with writes. > > As

[PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

2019-02-20 Thread Nikolaus Voss
Commit 1a2f474d328f handles block _reads_ separately with plain-I2C adapters, but the problem described with regmap-i2c not handling SMBus block transfers (i.e. read and writes) correctly also exists with writes. As workaround, this patch adds a block write function the same way 1a2f474d328f adds