Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 03:38:09PM -0800, Eric Biggers wrote: > I don't think backporting this change for other filesystems is particularly > important, since if I understand correctly, the reasons that Al made the > change > originally were: > > - to allow following symlinks in RCU mode, but

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 03:38:09PM -0800, Eric Biggers wrote: > I don't think backporting this change for other filesystems is particularly > important, since if I understand correctly, the reasons that Al made the > change > originally were: > > - to allow following symlinks in RCU mode, but

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 06:11:49PM -0500, Theodore Ts'o wrote: > On Tue, Feb 06, 2018 at 12:39:53PM -0800, Greg KH wrote: > > On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > > > From: Jin Qian > > > > > > partial backport from

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 06:11:49PM -0500, Theodore Ts'o wrote: > On Tue, Feb 06, 2018 at 12:39:53PM -0800, Greg KH wrote: > > On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > > > From: Jin Qian > > > > > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > > >

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 12:39:53PM -0800, Greg KH wrote: > On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > > From: Jin Qian > > > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > > to v4.4 to prevent virt_to_page on highmem. > > Ted, any

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 12:39:53PM -0800, Greg KH wrote: > On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > > From: Jin Qian > > > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > > to v4.4 to prevent virt_to_page on highmem. > > Ted, any objection to this

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > From: Jin Qian > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > to v4.4 to prevent virt_to_page on highmem. > > ext4_encrypted_follow_link uses kmap() for cpage > caddr = kmap(cpage);

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > From: Jin Qian > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > to v4.4 to prevent virt_to_page on highmem. > > ext4_encrypted_follow_link uses kmap() for cpage > caddr = kmap(cpage); > >

[PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

From: Jin Qian partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream to v4.4 to prevent virt_to_page on highmem. ext4_encrypted_follow_link uses kmap() for cpage caddr = kmap(cpage); _ext4_fname_disk_to_usr calls virt_to_page on the kmapped address.

[PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

From: Jin Qian partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream to v4.4 to prevent virt_to_page on highmem. ext4_encrypted_follow_link uses kmap() for cpage caddr = kmap(cpage); _ext4_fname_disk_to_usr calls virt_to_page on the kmapped address.