Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月28日 17:31, Lothar Waßmann 写道: > > Hi, > > > > Huang Shijie wrote: > >> 于 2014年03月28日 17:00, Sascha Hauer 写道: > >>> - disables swapping of BB marks in the FCB the ROM won't swap bytes. > >> We can not disable the swapping in the FCB in the imx28. > >> The DISBBM

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月28日 17:33, Huang Shijie 写道: > > 于 2014年03月28日 17:01, Lothar Waßmann 写道: > >> There is no need for the ROM code to access any other partition than > >> the bootloader itself. Thus Linux can perfectly well be booted from > > Assume the ROM only access the partitio

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Huang Shijie
于 2014年03月28日 17:31, Lothar Waßmann 写道: Hi, Huang Shijie wrote: 于 2014年03月28日 17:00, Sascha Hauer 写道: - disables swapping of BB marks in the FCB the ROM won't swap bytes. We can not disable the swapping in the FCB in the imx28. The DISBBM bit in the FCB does _NOT_ exit in the imx28's FCB. T

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Huang Shijie
于 2014年03月28日 17:33, Huang Shijie 写道: 于 2014年03月28日 17:01, Lothar Waßmann 写道: There is no need for the ROM code to access any other partition than the bootloader itself. Thus Linux can perfectly well be booted from Assume the ROM only access the partition which contains the bootloader, and the

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月28日 17:00, Sascha Hauer 写道: > > - disables swapping of BB marks in the FCB the ROM won't swap bytes. > We can not disable the swapping in the FCB in the imx28. > The DISBBM bit in the FCB does _NOT_ exit in the imx28's FCB. > The Linux kernel does not have any

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Huang Shijie
于 2014年03月28日 17:01, Lothar Waßmann 写道: There is no need for the ROM code to access any other partition than the bootloader itself. Thus Linux can perfectly well be booted from Assume the ROM only access the partition which contains the bootloader, and the ROM does the swapping for the pages(but

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Huang Shijie
于 2014年03月28日 17:00, Sascha Hauer 写道: - disables swapping of BB marks in the FCB the ROM won't swap bytes. We can not disable the swapping in the FCB in the imx28. The DISBBM bit in the FCB does _NOT_ exit in the imx28's FCB. thanks Huang Shijie -- To unsubscribe from this list: send the line

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月28日 16:16, Lothar Waßmann 写道: > > Still there is no need for the Linux NAND driver to be able to read or > > write partitions in a format that the Boot ROM can understand. Thus it > If you do not use the NAND boot, there really no need to do so. > There is no ne

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Sascha Hauer
On Fri, Mar 28, 2014 at 04:39:00PM +0800, Huang Shijie wrote: > 于 2014年03月28日 16:16, Lothar Waßmann 写道: > >Still there is no need for the Linux NAND driver to be able to read or > >write partitions in a format that the Boot ROM can understand. Thus it > If you do not use the NAND boot, there really

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Huang Shijie
于 2014年03月28日 16:16, Lothar Waßmann 写道: Still there is no need for the Linux NAND driver to be able to read or write partitions in a format that the Boot ROM can understand. Thus it If you do not use the NAND boot, there really no need to do so. Since you need the NAND boot, we should enable th

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-28 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月27日 20:21, Lothar Waßmann 写道: > > I can assure you that the>100.000 i.MX28 based modules, that we sold > > up to now boot from NAND just fine without any block mark swapping in > > the U-Boot pages. > > > Our driver should follow the Reference manual, not the pr

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-27 Thread Huang Shijie
于 2014年03月27日 20:21, Lothar Waßmann 写道: I can assure you that the>100.000 i.MX28 based modules, that we sold up to now boot from NAND just fine without any block mark swapping in the U-Boot pages. Our driver should follow the Reference manual, not the product. thanks Huang Shijie -- To unsubs

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-27 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > > > Please see "Figure 12-13" in the 12.12.1.12: > > >"In order to preserve the BI (bad block information), flash updater > > > or gang programmer > > > applications need to swap Bad Block Information (BI) data to byte 0 of > > > metadata area for > > > every page b

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-27 Thread Huang Shijie
On Wed, Mar 26, 2014 at 12:55:02PM +0100, Lothar Waßmann wrote: > Hi, > > Huang Shijie wrote: > > 于 2014年03月26日 16:51, Lothar Waßmann 写道: > > > I don't see why this should not be supported on i.MX28 (i.MX23 doesn't > > > do byteswapping anyway, so this wouldn't change anything for i.MX23). > > > T

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-26 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > 于 2014年03月26日 16:51, Lothar Waßmann 写道: > > I don't see why this should not be supported on i.MX28 (i.MX23 doesn't > > do byteswapping anyway, so this wouldn't change anything for i.MX23). > > The partitions used by Linux need not necessarily be accessible for the > > Boo

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-26 Thread Huang Shijie
于 2014年03月26日 16:51, Lothar Waßmann 写道: I don't see why this should not be supported on i.MX28 (i.MX23 doesn't do byteswapping anyway, so this wouldn't change anything for i.MX23). The partitions used by Linux need not necessarily be accessible for the Boot ROM code (and vice versa). But the fir

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-26 Thread Lothar Waßmann
Hi, Huang Shijie wrote: > On Fri, Mar 21, 2014 at 11:50:17AM +0100, Lothar Waßmann wrote: > > With a flash-based BBT there is no reason to move the Factory Bad > > Block Marker from the data area buffer (to where it is mapped by the > > GPMI NAND controller) to the OOB buffer. Thus, make this feat

Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-24 Thread Huang Shijie
On Fri, Mar 21, 2014 at 11:50:17AM +0100, Lothar Waßmann wrote: > With a flash-based BBT there is no reason to move the Factory Bad > Block Marker from the data area buffer (to where it is mapped by the > GPMI NAND controller) to the OOB buffer. Thus, make this feature > configurable via DT. This i

[PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

2014-03-21 Thread Lothar Waßmann
With a flash-based BBT there is no reason to move the Factory Bad Block Marker from the data area buffer (to where it is mapped by the GPMI NAND controller) to the OOB buffer. Thus, make this feature configurable via DT. This is required for the Ka-Ro electronics platforms. Signed-off-by: Lothar W