Re: [PATCHv2 1/1] perf: Port to Android

2012-08-24 Thread Ingo Molnar
* Alan Cox wrote: > On Fri, 24 Aug 2012 05:08:45 +0100 > Matthew Garrett wrote: > > > On Thu, Aug 23, 2012 at 03:32:50PM -0600, David Ahern wrote: > > > > > Why not add support for the missing functions (on_exit, getsid, > > > psignal and getline) to Bionic instead of perf? > > > > Many vend

Re: [PATCHv2 1/1] perf: Port to Android

2012-08-24 Thread Alan Cox
On Fri, 24 Aug 2012 05:08:45 +0100 Matthew Garrett wrote: > On Thu, Aug 23, 2012 at 03:32:50PM -0600, David Ahern wrote: > > > Why not add support for the missing functions (on_exit, getsid, > > psignal and getline) to Bionic instead of perf? > > Many vendors need to target existing Android pla

Re: [PATCHv2 1/1] perf: Port to Android

2012-08-24 Thread Namhyung Kim
On Fri, 24 Aug 2012 18:02:24 +0900, Namhyung Kim wrote: > On Thu, 23 Aug 2012 17:01:52 +0200, Bernhard Rosenkraenzer wrote: [SNIP] >> + >> +/* Assorted functions that are missing from Bionic */ >> +static void psignal(int sig, const char *s) >> +{ >> +if(sig >= 0 && sig < NSIG) { >> +

Re: [PATCHv2 1/1] perf: Port to Android

2012-08-24 Thread Namhyung Kim
Hi, Bernhard On Thu, 23 Aug 2012 17:01:52 +0200, Bernhard Rosenkraenzer wrote: > commit 4dc79eed16e3bb03b3cf92fcc6127e107e7537aa > Author: Bernhard Rosenkraenzer > Date: Sat Jun 23 06:18:05 2012 +0200 > > perf: Port to Android > > Adapt perf to deal with some missing functions in B

Re: [PATCHv2 1/1] perf: Port to Android

2012-08-24 Thread Ingo Molnar
* Matthew Garrett wrote: > On Thu, Aug 23, 2012 at 03:32:50PM -0600, David Ahern wrote: > > > Why not add support for the missing functions (on_exit, > > getsid, psignal and getline) to Bionic instead of perf? > > Many vendors need to target existing Android platforms and > don't have the lu

Re: [PATCHv2 1/1] perf: Port to Android

2012-08-23 Thread Matthew Garrett
On Thu, Aug 23, 2012 at 03:32:50PM -0600, David Ahern wrote: > Why not add support for the missing functions (on_exit, getsid, > psignal and getline) to Bionic instead of perf? Many vendors need to target existing Android platforms and don't have the luxury of waiting for code to get through Goo

Re: [PATCHv2 1/1] perf: Port to Android

2012-08-23 Thread David Ahern
On 8/23/12 2:51 PM, Pekka Enberg wrote: +#ifdef ANDROID +/* While stdlib.h has a prototype for it, + Bionic doesn't actually implement on_exit() */ +#ifndef ATEXIT_MAX +#define ATEXIT_MAX 32 +#endif +static int __on_exit_count = 0; +typedef void (*on_exit_func_t)(int, void*); +static on_exit_fu

Re: [PATCHv2 1/1] perf: Port to Android

2012-08-23 Thread Pekka Enberg
Hi Bernard, (You didn't CC perf maintainers.) On Thu, Aug 23, 2012 at 6:01 PM, Bernhard Rosenkraenzer wrote: > commit 4dc79eed16e3bb03b3cf92fcc6127e107e7537aa > Author: Bernhard Rosenkraenzer > Date: Sat Jun 23 06:18:05 2012 +0200 > > perf: Port to Android > > Adapt perf to deal with

[PATCHv2 1/1] perf: Port to Android

2012-08-23 Thread Bernhard Rosenkraenzer
commit 4dc79eed16e3bb03b3cf92fcc6127e107e7537aa Author: Bernhard Rosenkraenzer Date: Sat Jun 23 06:18:05 2012 +0200 perf: Port to Android Adapt perf to deal with some missing functions in Bionic etc. Change-Id: I0cda2aad3edba26e1be3aebc9475a229ea9e8356 Signed-off-by: B