Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-31 Thread Jonathan Cameron
On 27/10/15 16:13, Linus Walleij wrote: > On Sun, Oct 25, 2015 at 2:31 PM, Jonathan Cameron wrote: >> On 13/10/15 10:37, Paul Cercueil wrote: >>> Signed-off-by: Paul Cercueil >> Looks good to me, but as it is a little bit 'different' and we are >> defining entirely new generic bindings (the

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-31 Thread Jonathan Cameron
On 27/10/15 16:13, Linus Walleij wrote: > On Sun, Oct 25, 2015 at 2:31 PM, Jonathan Cameron wrote: >> On 13/10/15 10:37, Paul Cercueil wrote: >>> Signed-off-by: Paul Cercueil >> Looks good to me, but as it is a little bit 'different' and we are >>

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-27 Thread Linus Walleij
On Tue, Oct 27, 2015 at 5:13 PM, Linus Walleij wrote: > There are other problems though, but I comment on these > separately. Was wrong about that. I think this can go in like this. Later, this device may fork off a GPIO chip as well, but we will deal with that whenever we run into it. Yours,

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-27 Thread Linus Walleij
On Sun, Oct 25, 2015 at 2:31 PM, Jonathan Cameron wrote: > On 13/10/15 10:37, Paul Cercueil wrote: >> Signed-off-by: Paul Cercueil > Looks good to me, but as it is a little bit 'different' and we are > defining entirely new generic bindings (the channel modes stuff) > I would like some more

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-27 Thread Linus Walleij
On Sun, Oct 25, 2015 at 2:31 PM, Jonathan Cameron wrote: > On 13/10/15 10:37, Paul Cercueil wrote: >> Signed-off-by: Paul Cercueil > Looks good to me, but as it is a little bit 'different' and we are > defining entirely new generic bindings (the

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-27 Thread Linus Walleij
On Tue, Oct 27, 2015 at 5:13 PM, Linus Walleij wrote: > There are other problems though, but I comment on these > separately. Was wrong about that. I think this can go in like this. Later, this device may fork off a GPIO chip as well, but we will deal with that

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-25 Thread Jonathan Cameron
On 13/10/15 10:37, Paul Cercueil wrote: > Signed-off-by: Paul Cercueil Looks good to me, but as it is a little bit 'different' and we are defining entirely new generic bindings (the channel modes stuff) I would like some more input. It might be overkill but we do of course have the pinctl

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-25 Thread Jonathan Cameron
On 13/10/15 10:37, Paul Cercueil wrote: > Signed-off-by: Paul Cercueil Looks good to me, but as it is a little bit 'different' and we are defining entirely new generic bindings (the channel modes stuff) I would like some more input. It might be overkill but we do of

[PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-13 Thread Paul Cercueil
Signed-off-by: Paul Cercueil --- .../devicetree/bindings/iio/dac/ad5592r.txt| 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5592r.txt v2: Fix indentation issue diff --git

[PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-13 Thread Paul Cercueil
Signed-off-by: Paul Cercueil --- .../devicetree/bindings/iio/dac/ad5592r.txt| 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5592r.txt v2: Fix indentation issue diff --git