Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 20:43, Sarah Sharp wrote: > Applying: dev-core: fix build break when DEBUG is enabled > WARNING: Avoid unnecessary line continuations > #18: FILE: include/linux/device.h:1110: > +"callbacks suppressed" */\ > > WARNING: Prefer dev_dbg(... to de

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-28 Thread Sarah Sharp
Applying: dev-core: fix build break when DEBUG is enabled WARNING: Avoid unnecessary line continuations #18: FILE: include/linux/device.h:1110: + "callbacks suppressed" */\ WARNING: Prefer dev_dbg(... to dev_printk(KERN_DEBUG, ... #33: FILE: include/lin

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Dmitry Kasatkin
On Tue, Aug 27, 2013 at 9:16 PM, Joe Perches wrote: > On Tue, 2013-08-27 at 13:32 -0400, Jason Baron wrote: >> On 08/27/2013 12:20 PM, Joe Perches wrote: >> > On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote: >> >> When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data >> >> st

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Joe Perches
On Tue, 2013-08-27 at 13:32 -0400, Jason Baron wrote: > On 08/27/2013 12:20 PM, Joe Perches wrote: > > On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote: > >> When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data > >> structures even when CONFIG_DYNAMIC_DEBUG is not defined. > >

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Jason Baron
On 08/27/2013 12:20 PM, Joe Perches wrote: > On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote: >> When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data >> structures even when CONFIG_DYNAMIC_DEBUG is not defined. >> It leads to build break. >> For example, when I try to use dev

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Joe Perches
On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote: > When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data > structures even when CONFIG_DYNAMIC_DEBUG is not defined. > It leads to build break. > For example, when I try to use dev_dbg_ratelimited in USB code and > CONFIG_USB_DEB

[PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Dmitry Kasatkin
When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data structures even when CONFIG_DYNAMIC_DEBUG is not defined. It leads to build break. For example, when I try to use dev_dbg_ratelimited in USB code and CONFIG_USB_DEBUG is enabled, but CONFIG_DYNAMIC_DEBUG is not, I get: CC [M] dr