Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-08 Thread Ian Rogers
On Thu, Oct 8, 2020 at 2:12 AM Jiri Olsa wrote: > > On Tue, Oct 06, 2020 at 10:37:45AM +0900, Namhyung Kim wrote: > > On Sat, Oct 3, 2020 at 4:29 AM Jiri Olsa wrote: > > > > > > On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote: > > > > > > SNIP > > > > > > > > > + > > > > > > LIBJVMTI

Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-08 Thread Jiri Olsa
On Tue, Oct 06, 2020 at 10:37:45AM +0900, Namhyung Kim wrote: > On Sat, Oct 3, 2020 at 4:29 AM Jiri Olsa wrote: > > > > On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote: > > > > SNIP > > > > > > > + > > > > > LIBJVMTI = libperf-jvmti.so > > > > > > > > > > ifndef NO_JVMTI > > > > > @@

Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-05 Thread Namhyung Kim
On Sat, Oct 3, 2020 at 4:29 AM Jiri Olsa wrote: > > On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote: > > SNIP > > > > > + > > > > LIBJVMTI = libperf-jvmti.so > > > > > > > > ifndef NO_JVMTI > > > > @@ -756,6 +763,13 @@ $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c > > > >

Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-02 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers escreveu: > On Fri, Oct 2, 2020 at 6:07 AM Namhyung Kim wrote: > > > > Hi Jiri, > > > > On Fri, Oct 2, 2020 at 4:05 AM Jiri Olsa wrote: > > > > > > Adding test for build id cache that adds binary > > > with sha1 and md5 build ids and verifies

Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-02 Thread Jiri Olsa
On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote: SNIP > > > + > > > LIBJVMTI = libperf-jvmti.so > > > > > > ifndef NO_JVMTI > > > @@ -756,6 +763,13 @@ $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c > > > util/find-map.c > > > $(QUIET_CC)$(CC) -mx32 $(filter

Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-02 Thread Ian Rogers
On Fri, Oct 2, 2020 at 6:07 AM Namhyung Kim wrote: > > Hi Jiri, > > On Fri, Oct 2, 2020 at 4:05 AM Jiri Olsa wrote: > > > > Adding test for build id cache that adds binary > > with sha1 and md5 build ids and verifies it's > > added properly. > > > > The test updates build id cache with perf

Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-02 Thread Namhyung Kim
Hi Jiri, On Fri, Oct 2, 2020 at 4:05 AM Jiri Olsa wrote: > > Adding test for build id cache that adds binary > with sha1 and md5 build ids and verifies it's > added properly. > > The test updates build id cache with perf record > and perf buildid-cache -a. > > Signed-off-by: Jiri Olsa > --- >

[PATCHv2 1/9] perf tools: Add build id shell test

2020-10-01 Thread Jiri Olsa
Adding test for build id cache that adds binary with sha1 and md5 build ids and verifies it's added properly. The test updates build id cache with perf record and perf buildid-cache -a. Signed-off-by: Jiri Olsa --- v2 changes: - detect perf build directory when checking for build-ex* binaries