Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-21 Thread Miroslav Benes
On Thu, 20 Nov 2014, Seth Jennings wrote: > On Thu, Nov 20, 2014 at 11:35:52AM -0600, Josh Poimboeuf wrote: > > On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: > > > > > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > > > > > > This commit introduces code for the live patching

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-21 Thread Miroslav Benes
On Thu, 20 Nov 2014, Josh Poimboeuf wrote: > On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: > > > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > > > > This commit introduces code for the live patching core. It implements > > > an ftrace-based mechanism and kernel interface

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-21 Thread Miroslav Benes
On Thu, 20 Nov 2014, Josh Poimboeuf wrote: On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: On Sun, 16 Nov 2014, Seth Jennings wrote: This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel interface for doing live

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-21 Thread Miroslav Benes
On Thu, 20 Nov 2014, Seth Jennings wrote: On Thu, Nov 20, 2014 at 11:35:52AM -0600, Josh Poimboeuf wrote: On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: On Sun, 16 Nov 2014, Seth Jennings wrote: This commit introduces code for the live patching core. It

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Seth Jennings
On Thu, Nov 20, 2014 at 11:35:52AM -0600, Josh Poimboeuf wrote: > On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: > > > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > > > > This commit introduces code for the live patching core. It implements > > > an ftrace-based mechanism and

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Josh Poimboeuf
On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > > This commit introduces code for the live patching core. It implements > > an ftrace-based mechanism and kernel interface for doing live patching > > of kernel and kernel module

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Seth Jennings
On Thu, Nov 20, 2014 at 09:19:54AM -0600, Josh Poimboeuf wrote: > On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: > > +static int lpc_module_notify(struct notifier_block *nb, unsigned long > > action, > > + void *data) > > +{ > > + struct module *mod = data;

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Josh Poimboeuf
On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: > +static int lpc_module_notify(struct notifier_block *nb, unsigned long action, > + void *data) > +{ > + struct module *mod = data; > + struct lpc_patch *patch; > + struct lpc_object *obj; > + > +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Miroslav Benes
On Wed, 19 Nov 2014, Seth Jennings wrote: > On Tue, Nov 18, 2014 at 03:45:22PM +0100, Miroslav Benes wrote: > > > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > > > [...] > > > > > diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h > > > new file mode 100644 > > > index

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Miroslav Benes
On Sun, 16 Nov 2014, Seth Jennings wrote: > This commit introduces code for the live patching core. It implements > an ftrace-based mechanism and kernel interface for doing live patching > of kernel and kernel module functions. > > It represents the greatest common functionality set between

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Miroslav Benes
On Sun, 16 Nov 2014, Seth Jennings wrote: This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel interface for doing live patching of kernel and kernel module functions. It represents the greatest common functionality set between kpatch

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Miroslav Benes
On Wed, 19 Nov 2014, Seth Jennings wrote: On Tue, Nov 18, 2014 at 03:45:22PM +0100, Miroslav Benes wrote: On Sun, 16 Nov 2014, Seth Jennings wrote: [...] diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h new file mode 100644 index 000..8b68fef ---

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Josh Poimboeuf
On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: +static int lpc_module_notify(struct notifier_block *nb, unsigned long action, + void *data) +{ + struct module *mod = data; + struct lpc_patch *patch; + struct lpc_object *obj; + +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Seth Jennings
On Thu, Nov 20, 2014 at 09:19:54AM -0600, Josh Poimboeuf wrote: On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: +static int lpc_module_notify(struct notifier_block *nb, unsigned long action, + void *data) +{ + struct module *mod = data; +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Josh Poimboeuf
On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: On Sun, 16 Nov 2014, Seth Jennings wrote: This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel interface for doing live patching of kernel and kernel module functions.

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-20 Thread Seth Jennings
On Thu, Nov 20, 2014 at 11:35:52AM -0600, Josh Poimboeuf wrote: On Thu, Nov 20, 2014 at 02:10:33PM +0100, Miroslav Benes wrote: On Sun, 16 Nov 2014, Seth Jennings wrote: This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-19 Thread Seth Jennings
On Tue, Nov 18, 2014 at 03:45:22PM +0100, Miroslav Benes wrote: > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > [...] > > > diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h > > new file mode 100644 > > index 000..8b68fef > > --- /dev/null > > +++

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-19 Thread Seth Jennings
On Wed, Nov 19, 2014 at 04:27:39PM +0100, Miroslav Benes wrote: > > Hi, > > during rewriting our code I came across few more things. See below. > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > [...] > > > +/** > > + * module notifier > > +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-19 Thread Miroslav Benes
Hi, during rewriting our code I came across few more things. See below. On Sun, 16 Nov 2014, Seth Jennings wrote: [...] > +/** > + * module notifier > + */ > + > +static void lpc_module_notify_coming(struct module *pmod, > +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-19 Thread Miroslav Benes
Hi, during rewriting our code I came across few more things. See below. On Sun, 16 Nov 2014, Seth Jennings wrote: [...] +/** + * module notifier + */ + +static void lpc_module_notify_coming(struct module *pmod, +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-19 Thread Seth Jennings
On Wed, Nov 19, 2014 at 04:27:39PM +0100, Miroslav Benes wrote: Hi, during rewriting our code I came across few more things. See below. On Sun, 16 Nov 2014, Seth Jennings wrote: [...] +/** + * module notifier + */ +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-19 Thread Seth Jennings
On Tue, Nov 18, 2014 at 03:45:22PM +0100, Miroslav Benes wrote: On Sun, 16 Nov 2014, Seth Jennings wrote: [...] diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h new file mode 100644 index 000..8b68fef --- /dev/null +++ b/include/linux/livepatch.h @@ -0,0

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-18 Thread Miroslav Benes
On Sun, 16 Nov 2014, Seth Jennings wrote: [...] > diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h > new file mode 100644 > index 000..8b68fef > --- /dev/null > +++ b/include/linux/livepatch.h > @@ -0,0 +1,68 @@ > +/* > + * livepatch.h - Live Kernel Patching Core > + * > +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-18 Thread Seth Jennings
On Tue, Nov 18, 2014 at 03:11:43PM +0100, Miroslav Benes wrote: > > Hi, > > thank you for the revision. I'll rebase our patches on top of that. Anyway > there is a small bug in a header file. See below. > > On Sun, 16 Nov 2014, Seth Jennings wrote: > > [...] > > > diff --git

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-18 Thread Miroslav Benes
Hi, thank you for the revision. I'll rebase our patches on top of that. Anyway there is a small bug in a header file. See below. On Sun, 16 Nov 2014, Seth Jennings wrote: [...] > diff --git a/arch/x86/include/asm/livepatch.h b/arch/x86/include/asm/livepatch.h > new file mode 100644 > index

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-18 Thread Miroslav Benes
On Sun, 16 Nov 2014, Seth Jennings wrote: [...] diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h new file mode 100644 index 000..8b68fef --- /dev/null +++ b/include/linux/livepatch.h @@ -0,0 +1,68 @@ +/* + * livepatch.h - Live Kernel Patching Core + * + *

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-18 Thread Miroslav Benes
Hi, thank you for the revision. I'll rebase our patches on top of that. Anyway there is a small bug in a header file. See below. On Sun, 16 Nov 2014, Seth Jennings wrote: [...] diff --git a/arch/x86/include/asm/livepatch.h b/arch/x86/include/asm/livepatch.h new file mode 100644 index

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-18 Thread Seth Jennings
On Tue, Nov 18, 2014 at 03:11:43PM +0100, Miroslav Benes wrote: Hi, thank you for the revision. I'll rebase our patches on top of that. Anyway there is a small bug in a header file. See below. On Sun, 16 Nov 2014, Seth Jennings wrote: [...] diff --git

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-17 Thread Seth Jennings
On Mon, Nov 17, 2014 at 10:45:58AM -0800, Greg KH wrote: > On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: > > +#ifdef CONFIG_X86_32 > > +int lpc_write_module_reloc(struct module *mod, unsigned long type, > > + unsigned long loc, unsigned long value) > > +{ > >

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-17 Thread Greg KH
On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: > +#ifdef CONFIG_X86_32 > +int lpc_write_module_reloc(struct module *mod, unsigned long type, > +unsigned long loc, unsigned long value) > +{ > + pr_err("Live patching not supported on 32-bit x86\n"); > +

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-17 Thread Greg KH
On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: +#ifdef CONFIG_X86_32 +int lpc_write_module_reloc(struct module *mod, unsigned long type, +unsigned long loc, unsigned long value) +{ + pr_err(Live patching not supported on 32-bit x86\n); + return

Re: [PATCHv2 2/3] kernel: add support for live patching

2014-11-17 Thread Seth Jennings
On Mon, Nov 17, 2014 at 10:45:58AM -0800, Greg KH wrote: On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: +#ifdef CONFIG_X86_32 +int lpc_write_module_reloc(struct module *mod, unsigned long type, + unsigned long loc, unsigned long value) +{ +

[PATCHv2 2/3] kernel: add support for live patching

2014-11-16 Thread Seth Jennings
This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel interface for doing live patching of kernel and kernel module functions. It represents the greatest common functionality set between kpatch and kgraft and can accept patches built using

[PATCHv2 2/3] kernel: add support for live patching

2014-11-16 Thread Seth Jennings
This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel interface for doing live patching of kernel and kernel module functions. It represents the greatest common functionality set between kpatch and kgraft and can accept patches built using