Re: [PATCHv2 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-31 Thread Rohit Vaswani
On 5/31/2013 5:42 AM, Grant Likely wrote: On Wed, 22 May 2013 17:29:24 -0700, Rohit Vaswani wrote: This cleans up the gpio-msm-v2 driver of all the global define usage. The number of gpios are now defined in the device tree. This enables adding irqdomain support as well. Signed-off-by: Rohit

Re: [PATCHv2 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-31 Thread Grant Likely
On Fri, May 31, 2013 at 9:01 PM, Andy Shevchenko wrote: > On Thu, May 23, 2013 at 3:29 AM, Rohit Vaswani > wrote: >> This cleans up the gpio-msm-v2 driver of all the global define usage. >> The number of gpios are now defined in the device tree. This enables >> adding irqdomain support as well.

Re: [PATCHv2 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-31 Thread Andy Shevchenko
On Thu, May 23, 2013 at 3:29 AM, Rohit Vaswani wrote: > This cleans up the gpio-msm-v2 driver of all the global define usage. > The number of gpios are now defined in the device tree. This enables > adding irqdomain support as well. Besides the other comments, I have one important here. > -stati

Re: [PATCHv2 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-31 Thread Grant Likely
On Wed, 22 May 2013 17:29:24 -0700, Rohit Vaswani wrote: > This cleans up the gpio-msm-v2 driver of all the global define usage. > The number of gpios are now defined in the device tree. This enables > adding irqdomain support as well. > > Signed-off-by: Rohit Vaswani Hi Rohit, Comments below

Re: [PATCHv2 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-23 Thread Stanimir Varbanov
Hi Rohit, Thanks for the new version! I have few more comments below. On 05/23/2013 03:29 AM, Rohit Vaswani wrote: > This cleans up the gpio-msm-v2 driver of all the global define usage. > The number of gpios are now defined in the device tree. This enables > adding irqdomain support as well. >

[PATCHv2 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-22 Thread Rohit Vaswani
This cleans up the gpio-msm-v2 driver of all the global define usage. The number of gpios are now defined in the device tree. This enables adding irqdomain support as well. Signed-off-by: Rohit Vaswani --- .../devicetree/bindings/gpio/gpio-msm.txt | 26 +++ arch/arm/boot/dts/msm8660-s