Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-19 Thread Ricardo Ribalda
Hi Sergey On Fri, Mar 19, 2021 at 6:35 AM Sergey Senozhatsky wrote: > > On (21/03/18 22:19), Ricardo Ribalda wrote: > > > > > > May I please ask for more opinions on this? > > > > Could you try setting the roi in a loop in your device and verify that > > it accepts all the values with no modifica

Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-18 Thread Sergey Senozhatsky
On (21/03/18 22:19), Ricardo Ribalda wrote: > > > > May I please ask for more opinions on this? > > Could you try setting the roi in a loop in your device and verify that > it accepts all the values with no modification. If so we can implement > the set/get as a quirk for other devices. Tested on

Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-18 Thread Ricardo Ribalda
On Thu, Mar 18, 2021 at 10:19 PM Ricardo Ribalda wrote: > > Hi Sergey > > On Thu, Mar 18, 2021 at 5:47 AM Sergey Senozhatsky > wrote: > > > > On (21/03/17 08:58), Ricardo Ribalda Delgado wrote: > > [..] > > > > > > > > GET_CUR? > > > yep > > > > > > > > > > > > https://www.kernel.org/doc/html/v4.

Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-18 Thread Ricardo Ribalda
Hi Sergey On Thu, Mar 18, 2021 at 5:47 AM Sergey Senozhatsky wrote: > > On (21/03/17 08:58), Ricardo Ribalda Delgado wrote: > [..] > > > > > > GET_CUR? > > yep > > > > > > > > > https://www.kernel.org/doc/html/v4.13/media/uapi/v4l/vidioc-g-selection.html?highlight=vidioc_s_selection > > > > On su

Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-17 Thread Sergey Senozhatsky
On (21/03/17 08:58), Ricardo Ribalda Delgado wrote: [..] > > > > GET_CUR? > yep > > > > > > https://www.kernel.org/doc/html/v4.13/media/uapi/v4l/vidioc-g-selection.html?highlight=vidioc_s_selection > > > On success the struct v4l2_rect r field contains the adjusted > > > rectangle. > > > > What is

Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-17 Thread Ricardo Ribalda Delgado
Hi On Wed, Mar 17, 2021 at 2:59 AM Sergey Senozhatsky wrote: > > On (21/03/16 19:46), Ricardo Ribalda Delgado wrote: > > > -static int uvc_ioctl_g_selection(struct file *file, void *fh, > > > -struct v4l2_selection *sel) > > > +/* UVC 1.5 ROI rectangle is half the

Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-16 Thread Sergey Senozhatsky
On (21/03/16 19:46), Ricardo Ribalda Delgado wrote: > > -static int uvc_ioctl_g_selection(struct file *file, void *fh, > > -struct v4l2_selection *sel) > > +/* UVC 1.5 ROI rectangle is half the size of v4l2_rect */ > > +struct uvc_roi_rect { > > + __u16

Re: [PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-03-16 Thread Ricardo Ribalda Delgado
Hi Sergey Thanks for the patch On Mon, Feb 8, 2021 at 6:23 AM Sergey Senozhatsky wrote: > > From: Sergey Senozhatsky > > This patch implements parts of UVC 1.5 Region of Interest (ROI) > control, using the uvcvideo selection API. > > There are several things to mention here. > > First, UVC 1.5 d

[PATCHv2 3/3] media: uvcvideo: add UVC 1.5 ROI control

2021-02-07 Thread Sergey Senozhatsky
From: Sergey Senozhatsky This patch implements parts of UVC 1.5 Region of Interest (ROI) control, using the uvcvideo selection API. There are several things to mention here. First, UVC 1.5 defines CT_DIGITAL_WINDOW_CONTROL; and ROI rectangle coordinates "must be within the current Digital Windo