Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Mark Brown
On Fri, Nov 01, 2013 at 03:04:53PM +0800, Xiubo Li wrote: > Conflicts: > sound/soc/fsl/Makefile Ahem. > + /* TODO: The SAI driver should figure this out for us */ > + switch (channels) { > + case 2: > + snd_soc_dai_set_tdm_slot(cpu_dai, 0xfffc, 0xfffc, 2,

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Shawn Guo
On Fri, Nov 01, 2013 at 06:28:05PM +0800, Nicolin Chen wrote: > > sound/soc/fsl/fsl-sgtl5000-vf610.c | 208 > > + > > I just doubt if this file naming is appropriate. Even if we might not have > rigor rule for the file names, according to existing ones, they

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Oskar Schirmer
Not that it would improve functionality, but: On Fri, Nov 01, 2013 at 15:04:53 +0800, Xiubo Li wrote: [...] > diff --git a/sound/soc/fsl/fsl-sgtl5000-vf610.c > b/sound/soc/fsl/fsl-sgtl5000-vf610.c > new file mode 100644 > index 000..f535b42 > --- /dev/null > +++

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Nicolin Chen
Hi Xiubo, On Fri, Nov 01, 2013 at 03:04:53PM +0800, Xiubo Li wrote: > This is the SGTL5000 codec based audio driver supported with both > playback and capture dai link implemention. > > This implementation is only compatible with device tree definition. > > Signed-off-by: Alison Wang

[PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Xiubo Li
This is the SGTL5000 codec based audio driver supported with both playback and capture dai link implemention. This implementation is only compatible with device tree definition. Signed-off-by: Alison Wang Conflicts: sound/soc/fsl/Makefile --- sound/soc/fsl/Kconfig | 10

[PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Xiubo Li
This is the SGTL5000 codec based audio driver supported with both playback and capture dai link implemention. This implementation is only compatible with device tree definition. Signed-off-by: Alison Wang b18...@freescale.com Signed-off-by: Xiubo Li li.xi...@freescale.com Conflicts:

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Nicolin Chen
Hi Xiubo, On Fri, Nov 01, 2013 at 03:04:53PM +0800, Xiubo Li wrote: This is the SGTL5000 codec based audio driver supported with both playback and capture dai link implemention. This implementation is only compatible with device tree definition. Signed-off-by: Alison Wang

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Oskar Schirmer
Not that it would improve functionality, but: On Fri, Nov 01, 2013 at 15:04:53 +0800, Xiubo Li wrote: [...] diff --git a/sound/soc/fsl/fsl-sgtl5000-vf610.c b/sound/soc/fsl/fsl-sgtl5000-vf610.c new file mode 100644 index 000..f535b42 --- /dev/null +++

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Shawn Guo
On Fri, Nov 01, 2013 at 06:28:05PM +0800, Nicolin Chen wrote: sound/soc/fsl/fsl-sgtl5000-vf610.c | 208 + I just doubt if this file naming is appropriate. Even if we might not have rigor rule for the file names, according to existing ones, they are all

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Mark Brown
On Fri, Nov 01, 2013 at 03:04:53PM +0800, Xiubo Li wrote: Conflicts: sound/soc/fsl/Makefile Ahem. + /* TODO: The SAI driver should figure this out for us */ + switch (channels) { + case 2: + snd_soc_dai_set_tdm_slot(cpu_dai, 0xfffc, 0xfffc, 2, 0); +