Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

2015-03-13 Thread Sergey Senozhatsky
On (03/13/15 16:39), Minchan Kim wrote: > AFAIK, kernel rule doesn't prefer multi-line for printk string > because it makes hard to work with grep. Anyway, it's trivial. > For example, checkpatch will emit > > WARNING: quoted string split across lines > yes, exactly. that's why I mentioned it in

Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

2015-03-13 Thread Minchan Kim
On Fri, Mar 13, 2015 at 10:10:35AM +0900, Sergey Senozhatsky wrote: > Hi Minchan, > > On (03/13/15 08:55), Minchan Kim wrote: > > How about adding pid, comm? Admin can know which process touches. > > > > ok. > > > > struct zram *zram = dev_to_zram(d); \ > > > +

Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

2015-03-12 Thread Sergey Senozhatsky
Hi Minchan, On (03/13/15 08:55), Minchan Kim wrote: > How about adding pid, comm? Admin can know which process touches. > ok. > > struct zram *zram = dev_to_zram(d); \ > > + \ > > + deprecated_at

Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

2015-03-12 Thread Minchan Kim
Hi Sergey, On Thu, Mar 12, 2015 at 11:47:18PM +0900, Sergey Senozhatsky wrote: > Add Documentation/ABI/obsolete/sysfs-block-zram file and list > obsolete and deprecated attributes there. The patch also adds > additional information to zram documentation and describes the > basic strategy: > - the

[PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

2015-03-12 Thread Sergey Senozhatsky
Add Documentation/ABI/obsolete/sysfs-block-zram file and list obsolete and deprecated attributes there. The patch also adds additional information to zram documentation and describes the basic strategy: - the existing RW nodes will be downgraded to WO nodes (in 4.11) - deprecated RO sysfs nodes wil